Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: ppapi/proxy/tcp_socket_resource.cc

Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fixed implementation. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/tcp_socket_resource.cc
diff --git a/ppapi/proxy/tcp_socket_resource.cc b/ppapi/proxy/tcp_socket_resource.cc
index f8f8f68f26136158f83f56835360bde596ef0251..5466d0d23ab541c4a830aba38def51b3d29cc98f 100644
--- a/ppapi/proxy/tcp_socket_resource.cc
+++ b/ppapi/proxy/tcp_socket_resource.cc
@@ -115,10 +115,21 @@ void TCPSocketResource::Close() {
CloseImpl();
}
+int32_t TCPSocketResource::SetOption1_1(
+ PP_TCPSocket_Option name,
+ const PP_Var& value,
+ scoped_refptr<TrackedCallback> callback) {
+ return SetOptionImpl(name, value,
+ true, // Check connect() state.
+ callback);
+}
+
int32_t TCPSocketResource::SetOption(PP_TCPSocket_Option name,
const PP_Var& value,
scoped_refptr<TrackedCallback> callback) {
- return SetOptionImpl(name, value, callback);
+ return SetOptionImpl(name, value,
+ false, // Do not check connect() state.
+ callback);
}
PP_Resource TCPSocketResource::CreateAcceptedSocket(

Powered by Google App Engine
This is Rietveld 408576698