Issue 69003004: Have NodeTraversal::previous*() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69003004: Have NodeTraversal::previous*() take a reference (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
adamk

CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Have NodeTraversal::previous*() take a reference Have NodeTraversal::previous*() take a reference in argument instead of a pointer as the implementation expects the pointer to be non-null. This makes the code look safer and is consistent with NodeTraversal::next(). R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161861

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -66 lines)			Patch
M	Source/core/dom/ElementTraversal.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/dom/NodeIterator.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/dom/NodeTraversal.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/core/dom/NodeTraversal.cpp	View	3 chunks	+28 lines, -28 lines	0 comments	Download
M	Source/core/editing/ApplyStyleCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/ReplaceSelectionCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/VisibleUnits.cpp	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/forms/RadioInputType.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/FocusController.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderCounter.cpp	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderListItem.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/xml/XPathStep.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/69003004/1

7 years, 1 month ago (2013-11-12 22:24:39 UTC) #3

Message was sent while issue was closed.

Change committed as 161861

Expand Messages | Collapse Messages