Source/core/html/HTMLCollection.cpp - Issue 69003004: Have NodeTraversal::previous*() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCollection.cpp

Issue 69003004: Have NodeTraversal::previous*() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLCollection.cpp

diff --git a/Source/core/html/HTMLCollection.cpp b/Source/core/html/HTMLCollection.cpp

index b6e97846a2b1925cb0561d7564a40462ce690d61..4c40d0bc55a39b4d7f2fdbc70fee9ab48b2da4f0 100644

--- a/Source/core/html/HTMLCollection.cpp

+++ b/Source/core/html/HTMLCollection.cpp

@@ -255,7 +255,7 @@ template <> inline bool isMatchingElement(const ClassNodeList* nodeList, Element

static Node* previousNode(Node& base, Node& previous, bool onlyIncludeDirectChildren)

{

- return onlyIncludeDirectChildren ? previous.previousSibling() : NodeTraversal::previous(&previous, &base);

+ return onlyIncludeDirectChildren ? previous.previousSibling() : NodeTraversal::previous(previous, &base);

}

static inline Node* lastDescendent(Node& node)

« no previous file with comments | « Source/core/editing/VisibleUnits.cpp ('k') | Source/core/html/forms/RadioInputType.cpp » ('j') | no next file with comments »