Source/core/editing/ReplaceSelectionCommand.cpp - Issue 69003004: Have NodeTraversal::previous*() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 69003004: Have NodeTraversal::previous*() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index 3f6691d3d0ee2461759ecfebc3230e46b7fae6de..f86777b2ee129597dcadf87fefacdf53da26695b 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -346,7 +346,7 @@ inline void ReplaceSelectionCommand::InsertedNodes::willRemoveNode(Node& node)

} else if (m_firstNodeInserted == node)

m_firstNodeInserted = NodeTraversal::nextSkippingChildren(m_firstNodeInserted.get());

else if (m_lastNodeInserted == node)

- m_lastNodeInserted = NodeTraversal::previousSkippingChildren(m_lastNodeInserted.get());

+ m_lastNodeInserted = NodeTraversal::previousSkippingChildren(*m_lastNodeInserted);

}

inline void ReplaceSelectionCommand::InsertedNodes::didReplaceNode(Node& node, Node& newNode)

« no previous file with comments | « Source/core/editing/ApplyStyleCommand.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »