Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 689993004: [Suggestions Component] Add missing NULL check to ImageManager::OnImageFetched(). (Closed)

Created:
6 years, 1 month ago by huangs
Modified:
6 years, 1 month ago
Reviewers:
beaudoin, Mathieu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Suggestions Component] Add missing NULL check to ImageManager::OnImageFetched(). This fixes crashing bug. The check should be in ImageManager::OnImageFetched() instead of ImageFetcherImpl::OnFetchComplete(). Indeed, the unit test in image_fetcher_impl_browsertest.cc also allows it. Also added extra non-NULL DCHECK in ImageManager::GetImageURL(), and verified that current callers do not passing NULL to it. BUG=428117 TBR=mathp Committed: https://crrev.com/53313374f1ee883f825be0ac5f879d171be57a29 Cr-Commit-Position: refs/heads/master@{#302258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M components/suggestions/image_fetcher_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/suggestions/image_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
huangs
PTAL.
6 years, 1 month ago (2014-10-30 23:00:23 UTC) #2
beaudoin
lgtm
6 years, 1 month ago (2014-10-30 23:03:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689993004/1
6 years, 1 month ago (2014-10-30 23:37:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689993004/1
6 years, 1 month ago (2014-10-31 13:11:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 13:59:37 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/53313374f1ee883f825be0ac5f879d171be57a29 Cr-Commit-Position: refs/heads/master@{#302258}
6 years, 1 month ago (2014-10-31 14:00:13 UTC) #10
Mathieu
6 years, 1 month ago (2014-11-04 18:28:29 UTC) #11
Message was sent while issue was closed.
On 2014/10/31 14:00:13, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/53313374f1ee883f825be0ac5f879d171be57a29
> Cr-Commit-Position: refs/heads/master@{#302258}

lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698