Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1848)

Side by Side Diff: components/suggestions/image_fetcher_delegate.h

Issue 689993004: [Suggestions Component] Add missing NULL check to ImageManager::OnImageFetched(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/suggestions/image_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SUGGESTIONS_IMAGE_FETCHER_DELEGATE_H_ 5 #ifndef COMPONENTS_SUGGESTIONS_IMAGE_FETCHER_DELEGATE_H_
6 #define COMPONENTS_SUGGESTIONS_IMAGE_FETCHER_DELEGATE_H_ 6 #define COMPONENTS_SUGGESTIONS_IMAGE_FETCHER_DELEGATE_H_
7 7
8 class GURL; 8 class GURL;
9 class SkBitmap; 9 class SkBitmap;
10 10
11 namespace suggestions { 11 namespace suggestions {
12 12
13 class ImageFetcherDelegate { 13 class ImageFetcherDelegate {
14 public: 14 public:
15 ImageFetcherDelegate() {} 15 ImageFetcherDelegate() {}
16 16
17 // Called when an image was fetched. |url| represents the website for which 17 // Called when an image was fetched. |url| represents the website for which
18 // the image was fetched. |bitmap| is deleted once out of scope. 18 // the image was fetched. |bitmap| stores image data owned by the caller, and
19 // can be nullptr.
19 virtual void OnImageFetched(const GURL& url, const SkBitmap* bitmap) = 0; 20 virtual void OnImageFetched(const GURL& url, const SkBitmap* bitmap) = 0;
20 21
21 protected: 22 protected:
22 virtual ~ImageFetcherDelegate() {} 23 virtual ~ImageFetcherDelegate() {}
23 24
24 DISALLOW_COPY_AND_ASSIGN(ImageFetcherDelegate); 25 DISALLOW_COPY_AND_ASSIGN(ImageFetcherDelegate);
25 }; 26 };
26 27
27 } // namespace suggestions 28 } // namespace suggestions
28 29
29 #endif // COMPONENTS_SUGGESTIONS_IMAGE_FETCHER_DELEGATE_H_ 30 #endif // COMPONENTS_SUGGESTIONS_IMAGE_FETCHER_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | components/suggestions/image_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698