components/suggestions/image_fetcher_delegate.h - Issue 689993004: [Suggestions Component] Add missing NULL check to ImageManager::OnImageFetched().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/image_fetcher_delegate.h

Issue 689993004: [Suggestions Component] Add missing NULL check to ImageManager::OnImageFetched(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/suggestions/image_fetcher_delegate.h

diff --git a/components/suggestions/image_fetcher_delegate.h b/components/suggestions/image_fetcher_delegate.h

index f2335efe026284aa99307b3ff00d63ab7fd45c83..69fbb869bbeccdd5735d4726436cfd2a1f595aba 100644

--- a/components/suggestions/image_fetcher_delegate.h

+++ b/components/suggestions/image_fetcher_delegate.h

@@ -15,7 +15,8 @@ class ImageFetcherDelegate {

ImageFetcherDelegate() {}

// Called when an image was fetched. |url| represents the website for which

- // the image was fetched. |bitmap| is deleted once out of scope.

+ // the image was fetched. |bitmap| stores image data owned by the caller, and

+ // can be nullptr.

virtual void OnImageFetched(const GURL& url, const SkBitmap* bitmap) = 0;

protected:

« no previous file with comments | « no previous file | components/suggestions/image_manager.cc » ('j') | no next file with comments »