Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 689553002: Cleanup: Remove unneeded path_service.h includes in base and chrome. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vandebo (ex-Chrome), nkostylev+watch_chromium.org, tzik, posciak+watch_chromium.org, browser-components-watch_chromium.org, gavinp+memory_chromium.org, dcheng, Dmitry Titov, rginda+watch_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, jam, marja+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, dbeam+watch-options_chromium.org, jennb, yoshiki+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, jianli, oshima+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, Lei Zhang, tfarina, mcasas+watch_chromium.org, tommycli, Greg Billock, wfh+watch_chromium.org, James Su, wjia+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded path_service.h includes in base and chrome. Committed: https://crrev.com/2b010a6da29c67381864e6791332f14fbc56bff0 Cr-Commit-Position: refs/heads/master@{#303085}

Patch Set 1 #

Patch Set 2 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -97 lines) Patch
M base/file_version_info_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/linux_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/singleton_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app_shim/chrome_main_app_mode_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background/background_mode_manager_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_main_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_plugin_interactive_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/default_app_order_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_manager_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/sockets_tcp_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_udp/sockets_udp_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/system_network/system_network_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_websocket_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/hotword_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/user_script_loader_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/first_run/first_run_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_querying_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/top_sites_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/visit_database_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/importer/firefox_profile_lock_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc_log_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc_log_uploader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iapps_finder_impl_win_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/proxy_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_functional_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_list_desktop_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/database_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/shell_integration.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller_browsertest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/outdated_upgrade_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/set_as_default_browser_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/system_info_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/webdata/keyword_table_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/net/x509_certificate_model_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/install_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/browser_distribution.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/create_dir_work_item_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/delete_tree_work_item_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/product_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/work_item_list_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/interactive_test_utils_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/utility/media_galleries/picasa_album_table_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
stamp please
6 years, 1 month ago (2014-11-04 01:54:41 UTC) #2
Dan Beam
6 years, 1 month ago (2014-11-04 02:30:14 UTC) #3
Dan Beam
lgtm
6 years, 1 month ago (2014-11-04 02:30:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689553002/20001
6 years, 1 month ago (2014-11-06 19:44:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-06 20:32:45 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 20:33:23 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2b010a6da29c67381864e6791332f14fbc56bff0
Cr-Commit-Position: refs/heads/master@{#303085}

Powered by Google App Engine
This is Rietveld 408576698