Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: base/file_version_info_win.cc

Issue 689553002: Cleanup: Remove unneeded path_service.h includes in base and chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/linux_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_version_info_win.h" 5 #include "base/file_version_info_win.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 8
9 #include "base/file_version_info.h" 9 #include "base/file_version_info.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/path_service.h"
13 #include "base/threading/thread_restrictions.h" 12 #include "base/threading/thread_restrictions.h"
14 13
15 using base::FilePath; 14 using base::FilePath;
16 15
17 FileVersionInfoWin::FileVersionInfoWin(void* data, 16 FileVersionInfoWin::FileVersionInfoWin(void* data,
18 WORD language, 17 WORD language,
19 WORD code_page) 18 WORD code_page)
20 : language_(language), code_page_(code_page) { 19 : language_(language), code_page_(code_page) {
21 base::ThreadRestrictions::AssertIOAllowed(); 20 base::ThreadRestrictions::AssertIOAllowed();
22 data_.reset((char*) data); 21 data_.reset((char*) data);
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 return false; 181 return false;
183 } 182 }
184 183
185 std::wstring FileVersionInfoWin::GetStringValue(const wchar_t* name) { 184 std::wstring FileVersionInfoWin::GetStringValue(const wchar_t* name) {
186 std::wstring str; 185 std::wstring str;
187 if (GetValue(name, &str)) 186 if (GetValue(name, &str))
188 return str; 187 return str;
189 else 188 else
190 return L""; 189 return L"";
191 } 190 }
OLDNEW
« no previous file with comments | « no previous file | base/linux_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698