Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 689553002: Cleanup: Remove unneeded path_service.h includes in base and chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <string> 6 #include <string>
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/files/file_util.h" 12 #include "base/files/file_util.h"
13 #include "base/files/scoped_temp_dir.h" 13 #include "base/files/scoped_temp_dir.h"
14 #include "base/memory/scoped_ptr.h" 14 #include "base/memory/scoped_ptr.h"
15 #include "base/path_service.h"
16 #include "base/stl_util.h" 15 #include "base/stl_util.h"
17 #include "base/strings/string16.h" 16 #include "base/strings/string16.h"
18 #include "base/strings/utf_string_conversions.h" 17 #include "base/strings/utf_string_conversions.h"
19 #include "chrome/browser/history/expire_history_backend.h" 18 #include "chrome/browser/history/expire_history_backend.h"
20 #include "chrome/browser/history/history_database.h" 19 #include "chrome/browser/history/history_database.h"
21 #include "chrome/browser/history/thumbnail_database.h" 20 #include "chrome/browser/history/thumbnail_database.h"
22 #include "chrome/browser/history/top_sites.h" 21 #include "chrome/browser/history/top_sites.h"
23 #include "chrome/test/base/testing_profile.h" 22 #include "chrome/test/base/testing_profile.h"
24 #include "chrome/tools/profiles/thumbnail-inl.h" 23 #include "chrome/tools/profiles/thumbnail-inl.h"
25 #include "components/history/core/common/thumbnail_score.h" 24 #include "components/history/core/common/thumbnail_score.h"
(...skipping 843 matching lines...) Expand 10 before | Expand all | Expand 10 after
869 EXPECT_TRUE(all->Read(now, main_db_.get(), &visits, 1)); 868 EXPECT_TRUE(all->Read(now, main_db_.get(), &visits, 1));
870 EXPECT_EQ(1U, visits.size()); 869 EXPECT_EQ(1U, visits.size());
871 } 870 }
872 871
873 // TODO(brettw) add some visits with no URL to make sure everything is updated 872 // TODO(brettw) add some visits with no URL to make sure everything is updated
874 // properly. Have the visits also refer to nonexistent FTS rows. 873 // properly. Have the visits also refer to nonexistent FTS rows.
875 // 874 //
876 // Maybe also refer to invalid favicons. 875 // Maybe also refer to invalid favicons.
877 876
878 } // namespace history 877 } // namespace history
OLDNEW
« no previous file with comments | « chrome/browser/first_run/first_run_unittest.cc ('k') | chrome/browser/history/history_querying_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698