Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6893022: Add version-specific defines for each C interface. (Closed)

Created:
9 years, 8 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
polina
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Add version-specific defines for each C interface. This explicitly does not change any of the version numbers, and just makes the name of the define string match the current version number. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83176

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -40 lines) Patch
M ppapi/c/dev/ppb_buffer_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_char_set_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_console_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_context_3d_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_context_3d_trusted_dev.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_crypto_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_cursor_control_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_directory_reader_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_file_chooser_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_file_io_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_file_io_trusted_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_file_ref_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_file_system_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_find_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_font_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_font_list_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_fullscreen_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_gles_chromium_texture_mapping_dev.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_graphics_3d_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_opengles_dev.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_scrollbar_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_surface_3d_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_testing_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_transport_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_url_util_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_var_deprecated.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_video_decoder_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_widget_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_zoom_dev.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_audio.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_audio_config.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_core.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_graphics_2d.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_image_data.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_instance.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_messaging.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_url_loader.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_url_request_info.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_url_response_info.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/ppb_var.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
9 years, 8 months ago (2011-04-26 15:41:32 UTC) #1
polina
http://codereview.chromium.org/6893022/diff/2007/ppapi/c/dev/ppb_opengles_dev.h File ppapi/c/dev/ppb_opengles_dev.h (right): http://codereview.chromium.org/6893022/diff/2007/ppapi/c/dev/ppb_opengles_dev.h#newcode34 ppapi/c/dev/ppb_opengles_dev.h:34: #define PPB_OPENGLES2_DEV_INTERFACE_2 "PPB_OpenGLES(Dev);2.0" 2 or 2_0? http://codereview.chromium.org/6893022/diff/2007/ppapi/c/dev/ppb_zoom_dev.h File ppapi/c/dev/ppb_zoom_dev.h ...
9 years, 8 months ago (2011-04-27 03:40:26 UTC) #2
brettw
New snap up. http://codereview.chromium.org/6893022/diff/2007/ppapi/c/dev/ppb_opengles_dev.h File ppapi/c/dev/ppb_opengles_dev.h (right): http://codereview.chromium.org/6893022/diff/2007/ppapi/c/dev/ppb_opengles_dev.h#newcode34 ppapi/c/dev/ppb_opengles_dev.h:34: #define PPB_OPENGLES2_DEV_INTERFACE_2 "PPB_OpenGLES(Dev);2.0" Actually this string ...
9 years, 8 months ago (2011-04-27 03:50:47 UTC) #3
polina
9 years, 8 months ago (2011-04-27 03:59:36 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698