Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 688563002: ServiceWorker: Separate micro benchmark from application benchmark (Closed)

Created:
6 years, 1 month ago by shimazu
Modified:
6 years, 1 month ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@telemetry-newperf
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Separate micro benchmark from application benchmark Currently both of two are measured by one metric, but there is no meaning of JavaScript measurements in application test and of Speed Index in micro benchmark. This patch separate the two types of performance tests into different page_sets, and different measurements. BUG=372759 TEST=./tools/perf/run_benchmark --browser=android-chrome-shell service_worker.service_worker TEST=./tools/perf/run_benchmark --browser=android-chrome-shell service_worker.service_worker_micro_benchmark Committed: https://crrev.com/63fff39d062375b2049cd44ec95cde09a4cf0e5b Cr-Commit-Position: refs/heads/master@{#302521}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -59 lines) Patch
M tools/perf/benchmarks/service_worker.py View 1 4 chunks +52 lines, -10 lines 0 comments Download
M tools/perf/page_sets/data/service_worker.json View 1 chunk +2 lines, -4 lines 0 comments Download
D tools/perf/page_sets/data/service_worker_034.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A tools/perf/page_sets/data/service_worker_037.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/perf/page_sets/data/service_worker_micro_benchmark.json View 1 chunk +3 lines, -4 lines 0 comments Download
A tools/perf/page_sets/data/service_worker_micro_benchmark_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/service_worker.py View 1 2 1 chunk +2 lines, -25 lines 0 comments Download
A + tools/perf/page_sets/service_worker_micro_benchmark.py View 3 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
shimazu
Please review:)
6 years, 1 month ago (2014-10-29 02:16:59 UTC) #2
shimazu
ping?
6 years, 1 month ago (2014-10-31 06:02:17 UTC) #5
dtu
lgtm
6 years, 1 month ago (2014-11-03 22:45:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688563002/80001
6 years, 1 month ago (2014-11-03 22:46:40 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years, 1 month ago (2014-11-03 23:49:46 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 23:50:43 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/63fff39d062375b2049cd44ec95cde09a4cf0e5b
Cr-Commit-Position: refs/heads/master@{#302521}

Powered by Google App Engine
This is Rietveld 408576698