Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: tools/perf/page_sets/service_worker.py

Issue 688563002: ServiceWorker: Separate micro benchmark from application benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry-newperf
Patch Set: Fix a typo Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/service_worker.py
diff --git a/tools/perf/page_sets/service_worker.py b/tools/perf/page_sets/service_worker.py
index 23e2514b675dcacfd87dc9b85ada2af212df6117..aabb62a861a447a5ba7ba87b4b451598a3708f0a 100644
--- a/tools/perf/page_sets/service_worker.py
+++ b/tools/perf/page_sets/service_worker.py
@@ -9,39 +9,16 @@ from telemetry.page import page_set as page_set
archive_data_file_path = 'data/service_worker.json'
-class ServiceWorkerBenchmarkPage(page.Page):
- """Page for workload to measure some specific functions in JS"""
-
- def RunNavigateSteps(self, action_runner):
- action_runner.NavigateToPage(self)
- action_runner.WaitForJavaScriptCondition('window.done')
-
-
class ServiceWorkerPageSet(page_set.PageSet):
- """Page set which is using ServiceWorker"""
+ """Page set of applications using ServiceWorker"""
def __init__(self):
super(ServiceWorkerPageSet, self).__init__(
archive_data_file=archive_data_file_path,
make_javascript_deterministic=False,
- bucket=page_set.PUBLIC_BUCKET)
+ bucket=page_set.PARTNER_BUCKET)
- # pylint: disable=C0301
- # The code of localhost:8091 is placed in
- # https://github.com/coonsta/Service-Worker-Performance
- # but currently the following is used:
- # https://github.com/amiq11/Service-Worker-Performance/tree/follow_spec_and_many_registration
- # (rev: 3238098ea0225f53dab2f69f7406db8a2712dbf9)
- # This will be merged into the main repository.
- # pylint: enable=C0301
- # Why: to measure performance of many concurrent fetches
- self.AddPage(ServiceWorkerBenchmarkPage(
- 'http://localhost:8091/index.html', self))
- # Why: to measure performance of registrations
- self.AddPage(ServiceWorkerBenchmarkPage(
- 'http://localhost:8091/many-registration.html', self))
# Why: the first application using ServiceWorker
- # TODO(shimazu): Separate application tests from microbenchmark above two.
# 1st time: registration
self.AddPage(page.Page(
'https://jakearchibald.github.io/trained-to-thrill/', self))

Powered by Google App Engine
This is Rietveld 408576698