Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: tools/perf/page_sets/service_worker_micro_benchmark.py

Issue 688563002: ServiceWorker: Separate micro benchmark from application benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry-newperf
Patch Set: Fix a typo Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/service_worker.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/service_worker_micro_benchmark.py
diff --git a/tools/perf/page_sets/service_worker.py b/tools/perf/page_sets/service_worker_micro_benchmark.py
similarity index 65%
copy from tools/perf/page_sets/service_worker.py
copy to tools/perf/page_sets/service_worker_micro_benchmark.py
index 23e2514b675dcacfd87dc9b85ada2af212df6117..3e4ef30e792ce747cef5b32259881b267da5bf09 100644
--- a/tools/perf/page_sets/service_worker.py
+++ b/tools/perf/page_sets/service_worker_micro_benchmark.py
@@ -6,7 +6,7 @@ from telemetry.page import page as page
from telemetry.page import page_set as page_set
-archive_data_file_path = 'data/service_worker.json'
+archive_data_file_path = 'data/service_worker_micro_benchmark.json'
class ServiceWorkerBenchmarkPage(page.Page):
@@ -17,11 +17,11 @@ class ServiceWorkerBenchmarkPage(page.Page):
action_runner.WaitForJavaScriptCondition('window.done')
-class ServiceWorkerPageSet(page_set.PageSet):
- """Page set which is using ServiceWorker"""
+class ServiceWorkerMicroBenchmarkPageSet(page_set.PageSet):
+ """Page set for micro benchmarking of each functions with ServiceWorker"""
def __init__(self):
- super(ServiceWorkerPageSet, self).__init__(
+ super(ServiceWorkerMicroBenchmarkPageSet, self).__init__(
archive_data_file=archive_data_file_path,
make_javascript_deterministic=False,
bucket=page_set.PUBLIC_BUCKET)
@@ -40,14 +40,3 @@ class ServiceWorkerPageSet(page_set.PageSet):
# Why: to measure performance of registrations
self.AddPage(ServiceWorkerBenchmarkPage(
'http://localhost:8091/many-registration.html', self))
- # Why: the first application using ServiceWorker
- # TODO(shimazu): Separate application tests from microbenchmark above two.
- # 1st time: registration
- self.AddPage(page.Page(
- 'https://jakearchibald.github.io/trained-to-thrill/', self))
- # 2st time: 1st onfetch with caching
- self.AddPage(page.Page(
- 'https://jakearchibald.github.io/trained-to-thrill/', self))
- # 3rd time: 2nd onfetch from cache
- self.AddPage(page.Page(
- 'https://jakearchibald.github.io/trained-to-thrill/', self))
« no previous file with comments | « tools/perf/page_sets/service_worker.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698