Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 688433003: Remove viewportConstrained plumbing. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove viewportConstrained plumbing. Sky doesn't have viewport constrained elements (no position:fixed). R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/29233ae483337b3069c9289baa42a0d4489666d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -117 lines) Patch
M sky/engine/core/frame/FrameView.h View 4 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 4 chunks +0 lines, -58 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.h View 2 chunks +1 line, -4 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +2 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositingReasonFinder.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/compositing/CompositingReasonFinder.cpp View 3 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositingTriggers.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/graphics/CompositingReasons.h View 3 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/CompositingReasons.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-10-28 21:26:11 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-10-28 21:27:38 UTC) #3
ojan
6 years, 1 month ago (2014-10-28 21:28:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29233ae483337b3069c9289baa42a0d4489666d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698