Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: sky/engine/core/page/scrolling/ScrollingCoordinator.cpp

Issue 688433003: Remove viewportConstrained plumbing. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/page/scrolling/ScrollingCoordinator.h ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/sky/engine/core/page/scrolling/ScrollingCoordinator.cpp b/sky/engine/core/page/scrolling/ScrollingCoordinator.cpp
index e7d2af55ad1ced07f767ce6912c587c47b01adc9..d3efd68d04425ec2575d0d1675b7ad92ac50b650 100644
--- a/sky/engine/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/sky/engine/core/page/scrolling/ScrollingCoordinator.cpp
@@ -742,12 +742,6 @@ void ScrollingCoordinator::handleWheelEventPhase(PlatformWheelEventPhase phase)
}
#endif
-bool ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects(FrameView* frameView) const
-{
- // FIXME(sky): Remove
- return false;
-}
-
MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() const
{
MainThreadScrollingReasons reasons = static_cast<MainThreadScrollingReasons>(0);
@@ -758,26 +752,15 @@ MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() co
if (frameView->hasSlowRepaintObjects())
reasons |= HasSlowRepaintObjects;
- if (frameView->isScrollable() && hasVisibleSlowRepaintViewportConstrainedObjects(frameView))
- reasons |= HasNonLayerViewportConstrainedObjects;
return reasons;
}
String ScrollingCoordinator::mainThreadScrollingReasonsAsText(MainThreadScrollingReasons reasons)
{
- StringBuilder stringBuilder;
-
if (reasons & ScrollingCoordinator::HasSlowRepaintObjects)
- stringBuilder.appendLiteral("Has slow repaint objects, ");
- if (reasons & ScrollingCoordinator::HasViewportConstrainedObjectsWithoutSupportingFixedLayers)
- stringBuilder.appendLiteral("Has viewport constrained objects without supporting fixed layers, ");
- if (reasons & ScrollingCoordinator::HasNonLayerViewportConstrainedObjects)
- stringBuilder.appendLiteral("Has non-layer viewport-constrained objects, ");
-
- if (stringBuilder.length())
- stringBuilder.resize(stringBuilder.length() - 2);
- return stringBuilder.toString();
+ return "Has slow repaint objects";
+ return "";
}
String ScrollingCoordinator::mainThreadScrollingReasonsAsText() const
« no previous file with comments | « sky/engine/core/page/scrolling/ScrollingCoordinator.h ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698