sky/engine/core/rendering/RenderObject.h - Issue 688433003: Remove viewportConstrained plumbing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderObject.h

Issue 688433003: Remove viewportConstrained plumbing. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/engine/core/page/scrolling/ScrollingCoordinator.cpp ('k') | sky/engine/core/rendering/compositing/CompositingReasonFinder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/rendering/RenderObject.h

diff --git a/sky/engine/core/rendering/RenderObject.h b/sky/engine/core/rendering/RenderObject.h

index 5a995cfb1152278d98b04b87a5d7522cf30820f6..28f28bb2794f55f0f1bb6389327be9867098ef82 100644

--- a/sky/engine/core/rendering/RenderObject.h

+++ b/sky/engine/core/rendering/RenderObject.h

@@ -740,8 +740,6 @@ public:

// Given a rect in the object's coordinate space, compute a rect suitable for invalidating paints of

// that rect in the coordinate space of paintInvalidationContainer.

- // The ViewportConstrainedPosition parameter is only meaningful when this object is RenderView.

- // For other objects, the caller can just pass |ViewportConstraintDoesNotMatter|.

virtual void mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const;

virtual void computeFloatRectForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer, FloatRect& paintInvalidationRect, const PaintInvalidationState*) const;