Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 688233002: Remove writing mode code from the linebox tree. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove writing mode code from the linebox tree. Yo dawg, I heard you like ternaries. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4e7d524f6320d0ce355cc9305a4a63183e380a89

Patch Set 1 #

Patch Set 2 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -212 lines) Patch
M sky/engine/core/rendering/EllipsisBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/EllipsisBox.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/rendering/InlineBox.h View 8 chunks +15 lines, -33 lines 0 comments Download
M sky/engine/core/rendering/InlineBox.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.h View 3 chunks +10 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 9 chunks +24 lines, -78 lines 0 comments Download
M sky/engine/core/rendering/InlineTextBox.cpp View 11 chunks +15 lines, -25 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLineBoxList.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderText.cpp View 4 chunks +8 lines, -23 lines 0 comments Download
M sky/engine/core/rendering/RootInlineBox.cpp View 9 chunks +12 lines, -21 lines 0 comments Download
M sky/engine/core/rendering/style/ShadowList.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/style/ShadowList.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ojan
6 years, 1 month ago (2014-10-30 03:29:21 UTC) #2
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-30 03:29:32 UTC) #4
ojan
Committed patchset #2 (id:20001) manually as 4e7d524f6320d0ce355cc9305a4a63183e380a89.
6 years, 1 month ago (2014-10-30 03:30:03 UTC) #5
eseidel
6 years, 1 month ago (2014-10-30 16:20:36 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698