sky/engine/core/rendering/RenderBlockLineLayout.cpp - Issue 688233002: Remove writing mode code from the linebox tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBlockLineLayout.cpp

Issue 688233002: Remove writing mode code from the linebox tree. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: merge to ToT Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBlockLineLayout.cpp

diff --git a/sky/engine/core/rendering/RenderBlockLineLayout.cpp b/sky/engine/core/rendering/RenderBlockLineLayout.cpp

index 9a93741102305552276953cc8a75aba53cb3315c..60191f547d73d155d9ccaa4fe31faf7e4371c7e2 100644

--- a/sky/engine/core/rendering/RenderBlockLineLayout.cpp

+++ b/sky/engine/core/rendering/RenderBlockLineLayout.cpp

@@ -113,8 +113,6 @@ InlineFlowBox* RenderBlockFlow::createLineBoxes(RenderObject* obj, const LineInf

ASSERT_WITH_SECURITY_IMPLICATION(newBox->isInlineFlowBox());

parentBox = toInlineFlowBox(newBox);

parentBox->setFirstLineStyleBit(lineInfo.isFirstLine());

- // FIXME(sky): Remove

- parentBox->setIsHorizontal(true);

if (!hasDefaultLineBoxContain)

parentBox->clearDescendantsHaveSameLineHeightAndBaseline();

constructedNewBox = true;