Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 688043003: Maintain focused column in chrome://settings/searchEngines (Closed)

Created:
6 years, 1 month ago by bondd
Modified:
6 years, 1 month ago
Reviewers:
*Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@split1_05
Project:
chromium
Visibility:
Public.

Description

Maintain focused column in chrome://settings/searchEngines 1. Focused column is maintained when pressing up/down in list to change selected list item. 2. Shift+Tab from outside of the list now goes to the last list item field instead of the first one. This CL is part of splitting https://codereview.chromium.org/664583006/ into several smaller CLs. All applicable reviewer comments from that CL have been addressed. This CL depends on https://codereview.chromium.org/683813004/ BUG=428428 Committed: https://crrev.com/39698bd5cf1a61e67796b9a855f32321a1d29242 Cr-Commit-Position: refs/heads/master@{#303933}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Incorporate reviewer comments from dbeam@ #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -21 lines) Patch
M chrome/browser/resources/options/inline_editable_list.js View 1 2 10 chunks +134 lines, -9 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager_engine_list.js View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/list.js View 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
bondd
Ready for review. This CL was split from https://codereview.chromium.org/664583006/ I responded to the old reviewer ...
6 years, 1 month ago (2014-10-29 21:14:21 UTC) #3
Dan Beam
https://codereview.chromium.org/688043003/diff/1/chrome/browser/resources/options/inline_editable_list.js File chrome/browser/resources/options/inline_editable_list.js (right): https://codereview.chromium.org/688043003/diff/1/chrome/browser/resources/options/inline_editable_list.js#newcode37 chrome/browser/resources/options/inline_editable_list.js:37: focusedColumnIndex: -1, On 2014/10/29 21:14:21, bondd wrote: > Is ...
6 years, 1 month ago (2014-10-29 22:39:07 UTC) #4
bondd
Addressed reviewer comments from dbeam@. https://codereview.chromium.org/688043003/diff/1/chrome/browser/resources/options/inline_editable_list.js File chrome/browser/resources/options/inline_editable_list.js (right): https://codereview.chromium.org/688043003/diff/1/chrome/browser/resources/options/inline_editable_list.js#newcode37 chrome/browser/resources/options/inline_editable_list.js:37: focusedColumnIndex: -1, On 2014/10/29 ...
6 years, 1 month ago (2014-10-29 23:45:25 UTC) #5
Dan Beam
https://codereview.chromium.org/688043003/diff/1/chrome/browser/resources/options/inline_editable_list.js File chrome/browser/resources/options/inline_editable_list.js (right): https://codereview.chromium.org/688043003/diff/1/chrome/browser/resources/options/inline_editable_list.js#newcode457 chrome/browser/resources/options/inline_editable_list.js:457: return element.getAttribute('inlineeditable-column'); On 2014/10/29 23:45:25, bondd wrote: > On ...
6 years, 1 month ago (2014-10-30 19:34:45 UTC) #6
bondd
https://codereview.chromium.org/688043003/diff/1/chrome/browser/resources/options/inline_editable_list.js File chrome/browser/resources/options/inline_editable_list.js (right): https://codereview.chromium.org/688043003/diff/1/chrome/browser/resources/options/inline_editable_list.js#newcode457 chrome/browser/resources/options/inline_editable_list.js:457: return element.getAttribute('inlineeditable-column'); On 2014/10/30 19:34:45, Dan Beam wrote: > ...
6 years, 1 month ago (2014-10-30 20:34:06 UTC) #7
Dan Beam
lgtm
6 years, 1 month ago (2014-10-30 22:29:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/688043003/40001
6 years, 1 month ago (2014-11-12 23:18:09 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-13 00:17:04 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 00:17:39 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/39698bd5cf1a61e67796b9a855f32321a1d29242
Cr-Commit-Position: refs/heads/master@{#303933}

Powered by Google App Engine
This is Rietveld 408576698