Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 688043003: Maintain focused column in chrome://settings/searchEngines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split1_05
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/inline_editable_list.js ('k') | ui/webui/resources/js/cr/ui/list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/search_engine_manager_engine_list.js
diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js
index 8d933676d81032766c699a7c89a29cffebdbbdc4..e36fcd355071525d5544a5e02a20d563f8e11c9c 100644
--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js
+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js
@@ -140,6 +140,7 @@ cr.define('options.search_engines', function() {
// And the URL column.
var urlEl = this.createEditableTextCell(engine.url);
+ var makeDefaultButtonEl;
// Extensions should not display a URL column.
if (!engine.isOmniboxExtension) {
var urlWithButtonEl = this.ownerDocument.createElement('div');
@@ -151,7 +152,7 @@ cr.define('options.search_engines', function() {
// re-ordering is implemented. When this is removed, remove the extra
// div above.
if (engine.canBeDefault) {
- var makeDefaultButtonEl = this.ownerDocument.createElement('button');
+ makeDefaultButtonEl = this.ownerDocument.createElement('button');
makeDefaultButtonEl.className =
'custom-appearance list-inline-button';
makeDefaultButtonEl.textContent =
@@ -190,6 +191,12 @@ cr.define('options.search_engines', function() {
loadTimeData.getString('searchEngineTableURLPlaceholder');
}
+ this.setFocusableColumnIndex(this.nameField_, 0);
+ this.setFocusableColumnIndex(this.keywordField_, 1);
+ this.setFocusableColumnIndex(this.urlField_, 2);
+ this.setFocusableColumnIndex(makeDefaultButtonEl, 3);
+ this.setFocusableColumnIndex(this.closeButtonElement, 4);
+
var fields = [this.nameField_, this.keywordField_, this.urlField_];
for (var i = 0; i < fields.length; i++) {
fields[i].oninput = this.startFieldValidation_.bind(this);
« no previous file with comments | « chrome/browser/resources/options/inline_editable_list.js ('k') | ui/webui/resources/js/cr/ui/list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698