Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 68793009: Move files from the secondary GN directory to build. (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
7 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Move files from the secondary GN directory to build. Since this build is looking less experimental, I'm moving the files out of secondary into the corresponding location in src/build. I added owners files that just include me. For now I'd like to review all changes here. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236319

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-13 lines, -2370 lines) Patch
A + build/config/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/config/BUILDCONFIG.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/config/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + build/config/clang/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/config/compiler/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/config/linux/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/config/linux/pkg-config.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/config/mac/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/config/win/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/config/win/get_msvc_config.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/config/win/get_msvc_config_real.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/toolchain/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + build/toolchain/linux/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/toolchain/mac/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/toolchain/mac/setup_toolchain.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/toolchain/nacl/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/toolchain/win/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/toolchain/win/setup_toolchain.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/util/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A build/util/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
D tools/gn/secondary/build/config/BUILD.gn View 1 chunk +0 lines, -50 lines 0 comments Download
D tools/gn/secondary/build/config/BUILDCONFIG.gn View 1 chunk +0 lines, -388 lines 0 comments Download
D tools/gn/secondary/build/config/clang/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D tools/gn/secondary/build/config/compiler/BUILD.gn View 1 chunk +0 lines, -396 lines 0 comments Download
D tools/gn/secondary/build/config/linux/BUILD.gn View 1 chunk +0 lines, -86 lines 0 comments Download
D tools/gn/secondary/build/config/linux/pkg-config.py View 1 chunk +0 lines, -76 lines 0 comments Download
D tools/gn/secondary/build/config/mac/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/gn/secondary/build/config/win/BUILD.gn View 1 chunk +0 lines, -148 lines 0 comments Download
D tools/gn/secondary/build/config/win/get_msvc_config.py View 1 chunk +0 lines, -77 lines 0 comments Download
D tools/gn/secondary/build/config/win/get_msvc_config_real.py View 1 chunk +0 lines, -575 lines 0 comments Download
D tools/gn/secondary/build/toolchain/linux/BUILD.gn View 1 chunk +0 lines, -122 lines 0 comments Download
D tools/gn/secondary/build/toolchain/mac/BUILD.gn View 1 chunk +0 lines, -82 lines 0 comments Download
D tools/gn/secondary/build/toolchain/mac/setup_toolchain.py View 1 chunk +0 lines, -29 lines 0 comments Download
D tools/gn/secondary/build/toolchain/nacl/BUILD.gn View 1 chunk +0 lines, -62 lines 0 comments Download
D tools/gn/secondary/build/toolchain/win/BUILD.gn View 1 chunk +0 lines, -161 lines 0 comments Download
D tools/gn/secondary/build/toolchain/win/setup_toolchain.py View 1 chunk +0 lines, -72 lines 0 comments Download
D tools/gn/secondary/build/util/BUILD.gn View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years, 1 month ago (2013-11-19 23:36:30 UTC) #1
scottmg
lgtm No OWNERS on build/util/BUILD.gn if you care to set a per-file.
7 years, 1 month ago (2013-11-19 23:39:56 UTC) #2
brettw
7 years, 1 month ago (2013-11-20 22:21:06 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r236319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698