Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 687913002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 1 month ago by RAGHURAM
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: static v8::Handle<v8::Value> createSyntaxError(const String&, v8::Isolate*) static v8::Handle<v8::Value> throwSyntaxError(const String&, v8::Isolate*) static v8::Handle<v8::Value> createReferenceError(const String&, v8::Isolate*) static v8::Handle<v8::Value> throwReferenceError(const String&, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M Source/bindings/core/v8/V8NPObject.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/core/v8/V8ThrowException.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8ThrowException.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 1 month ago (2014-10-29 07:42:37 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-10-29 08:45:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687913002/1
6 years, 1 month ago (2014-10-29 09:31:12 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 10:41:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184579

Powered by Google App Engine
This is Rietveld 408576698