Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: Source/bindings/core/v8/V8ThrowException.cpp

Issue 687913002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8ThrowException.cpp
diff --git a/Source/bindings/core/v8/V8ThrowException.cpp b/Source/bindings/core/v8/V8ThrowException.cpp
index 92b4fc7e34d6b4594e8f9d7cbdf47b79dfb8539a..1463ac2bbfc7194d349684e2b952e0d4cb155984 100644
--- a/Source/bindings/core/v8/V8ThrowException.cpp
+++ b/Source/bindings/core/v8/V8ThrowException.cpp
@@ -58,9 +58,9 @@ v8::Handle<v8::Value> V8ThrowException::createDOMException(int ec, const String&
if (ec == V8RangeError)
return V8ThrowException::createRangeError(sanitizedMessage, isolate);
if (ec == V8SyntaxError)
- return V8ThrowException::createSyntaxError(sanitizedMessage, isolate);
+ return V8ThrowException::createSyntaxError(isolate, sanitizedMessage);
if (ec == V8ReferenceError)
- return V8ThrowException::createReferenceError(sanitizedMessage, isolate);
+ return V8ThrowException::createReferenceError(isolate, sanitizedMessage);
RefPtrWillBeRawPtr<DOMException> domException = DOMException::create(ec, sanitizedMessage, unsanitizedMessage);
v8::Handle<v8::Value> exception = toV8(domException, creationContext, isolate);
@@ -121,25 +121,25 @@ v8::Handle<v8::Value> V8ThrowException::throwRangeError(const String& message, v
return V8ThrowException::throwException(exception, isolate);
}
-v8::Handle<v8::Value> V8ThrowException::createSyntaxError(const String& message, v8::Isolate* isolate)
+v8::Handle<v8::Value> V8ThrowException::createSyntaxError(v8::Isolate* isolate, const String& message)
{
return v8::Exception::SyntaxError(v8String(isolate, message.isNull() ? "Syntax error" : message));
}
-v8::Handle<v8::Value> V8ThrowException::throwSyntaxError(const String& message, v8::Isolate* isolate)
+v8::Handle<v8::Value> V8ThrowException::throwSyntaxError(v8::Isolate* isolate, const String& message)
{
- v8::Handle<v8::Value> exception = V8ThrowException::createSyntaxError(message, isolate);
+ v8::Handle<v8::Value> exception = V8ThrowException::createSyntaxError(isolate, message);
return V8ThrowException::throwException(exception, isolate);
}
-v8::Handle<v8::Value> V8ThrowException::createReferenceError(const String& message, v8::Isolate* isolate)
+v8::Handle<v8::Value> V8ThrowException::createReferenceError(v8::Isolate* isolate, const String& message)
{
return v8::Exception::ReferenceError(v8String(isolate, message.isNull() ? "Reference error" : message));
}
-v8::Handle<v8::Value> V8ThrowException::throwReferenceError(const String& message, v8::Isolate* isolate)
+v8::Handle<v8::Value> V8ThrowException::throwReferenceError(v8::Isolate* isolate, const String& message)
{
- v8::Handle<v8::Value> exception = V8ThrowException::createReferenceError(message, isolate);
+ v8::Handle<v8::Value> exception = V8ThrowException::createReferenceError(isolate, message);
return V8ThrowException::throwException(exception, isolate);
}
« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698