Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: Source/bindings/core/v8/V8NPObject.cpp

Issue 687913002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8ThrowException.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8NPObject.cpp
diff --git a/Source/bindings/core/v8/V8NPObject.cpp b/Source/bindings/core/v8/V8NPObject.cpp
index 25173cd8a33c66c26e04d5e025fcca7f08cdf7ca..5401a59314a08a9326a58345ceef933605d1dbd1 100644
--- a/Source/bindings/core/v8/V8NPObject.cpp
+++ b/Source/bindings/core/v8/V8NPObject.cpp
@@ -91,7 +91,7 @@ static void npObjectInvokeImpl(const v8::FunctionCallbackInfo<v8::Value>& info,
// The holder object is not a subtype of HTMLPlugInElement, it must be an NPObject which has three
// internal fields.
if (info.Holder()->InternalFieldCount() != npObjectInternalFieldCount) {
- V8ThrowException::throwReferenceError("NPMethod called on non-NPObject", info.GetIsolate());
+ V8ThrowException::throwReferenceError(info.GetIsolate(), "NPMethod called on non-NPObject");
return;
}
@@ -100,7 +100,7 @@ static void npObjectInvokeImpl(const v8::FunctionCallbackInfo<v8::Value>& info,
// Verify that our wrapper wasn't using a NPObject which has already been deleted.
if (!npObject || !_NPN_IsAlive(npObject)) {
- V8ThrowException::throwReferenceError("NPObject deleted", isolate);
+ V8ThrowException::throwReferenceError(isolate, "NPObject deleted");
return;
}
@@ -240,12 +240,12 @@ static v8::Handle<v8::Value> npObjectGetProperty(v8::Local<v8::Object> self, NPI
// Verify that our wrapper wasn't using a NPObject which
// has already been deleted.
if (!npObject || !_NPN_IsAlive(npObject))
- return V8ThrowException::throwReferenceError("NPObject deleted", isolate);
+ return V8ThrowException::throwReferenceError(isolate, "NPObject deleted");
if (npObject->_class->hasProperty && npObject->_class->getProperty && npObject->_class->hasProperty(npObject, identifier)) {
if (!_NPN_IsAlive(npObject))
- return V8ThrowException::throwReferenceError("NPObject deleted", isolate);
+ return V8ThrowException::throwReferenceError(isolate, "NPObject deleted");
NPVariant result;
VOID_TO_NPVARIANT(result);
@@ -261,11 +261,11 @@ static v8::Handle<v8::Value> npObjectGetProperty(v8::Local<v8::Object> self, NPI
}
if (!_NPN_IsAlive(npObject))
- return V8ThrowException::throwReferenceError("NPObject deleted", isolate);
+ return V8ThrowException::throwReferenceError(isolate, "NPObject deleted");
if (key->IsString() && npObject->_class->hasMethod && npObject->_class->hasMethod(npObject, identifier)) {
if (!_NPN_IsAlive(npObject))
- return V8ThrowException::throwReferenceError("NPObject deleted", isolate);
+ return V8ThrowException::throwReferenceError(isolate, "NPObject deleted");
PrivateIdentifier* id = static_cast<PrivateIdentifier*>(identifier);
v8::Local<v8::FunctionTemplate> functionTemplate = V8NPTemplateMap::sharedInstance(isolate).get(id);
@@ -322,13 +322,13 @@ static v8::Handle<v8::Value> npObjectSetProperty(v8::Local<v8::Object> self, NPI
// Verify that our wrapper wasn't using a NPObject which has already been deleted.
if (!npObject || !_NPN_IsAlive(npObject)) {
- V8ThrowException::throwReferenceError("NPObject deleted", isolate);
+ V8ThrowException::throwReferenceError(isolate, "NPObject deleted");
return value; // Intercepted, but an exception was thrown.
}
if (npObject->_class->hasProperty && npObject->_class->setProperty && npObject->_class->hasProperty(npObject, identifier)) {
if (!_NPN_IsAlive(npObject))
- return V8ThrowException::throwReferenceError("NPObject deleted", isolate);
+ return V8ThrowException::throwReferenceError(isolate, "NPObject deleted");
NPVariant npValue;
VOID_TO_NPVARIANT(npValue);
@@ -374,7 +374,7 @@ void npObjectPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info,
// Verify that our wrapper wasn't using a NPObject which
// has already been deleted.
if (!npObject || !_NPN_IsAlive(npObject)) {
- V8ThrowException::throwReferenceError("NPObject deleted", info.GetIsolate());
+ V8ThrowException::throwReferenceError(info.GetIsolate(), "NPObject deleted");
return;
}
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8ThrowException.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698