Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 687793004: mojom: Remove braces from module statements and make them come first. (Closed)

Created:
6 years, 1 month ago by viettrungluu
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

mojom: Remove braces from module statements and make them come first. So, instead of: import "bar.mojom"; module foo { ... } You'll do: module foo; import "bar.mojom"; ... (Note that the grammar in the parser doesn't capture the ordering constraint. It's hard to do so while keeping the grammar LR(1) AFAICT. So instead we enforce the ordering "manually".) Also delete mojo/spy/PRESUBMIT.py since it's broken. We'll delete mojo/spy separately. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a08257c158b67dee27fba993b518fa67ff725a06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -334 lines) Patch
M examples/apptest/example_service.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M examples/echo/echo_service.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M examples/keyboard/keyboard.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M examples/media_viewer/media_viewer.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M examples/window_manager/window_manager.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M examples/wm_flow/app/embedder.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M examples/wm_flow/embedded/embeddee.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/application_manager/test.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/apps/js/test/js_to_cpp.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/application/application.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/interfaces/application/service_provider.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/application/shell.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/math_calculator.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/rect.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/regression_tests.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_factory.mojom View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import2.mojom View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_interfaces.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/serialization_test_structs.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/ast.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 2 chunks +29 lines, -23 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 22 chunks +93 lines, -48 lines 0 comments Download
M mojo/services/public/interfaces/clipboard/clipboard.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/content_handler/content_handler.mojom View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/geometry/geometry.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/gpu/command_buffer.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/gpu/gpu.mojom View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_event_constants.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_key_codes.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/navigation/navigation.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/cookie_store.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/network/net_address.mojom View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/network_error.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/network/network_service.mojom View 3 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_bound_socket.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_connected_socket.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_server_socket.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/udp_socket.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/url_loader.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/web_socket.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/quads.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surface_id.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces_service.mojom View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager_constants.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager.mojom View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager_internal.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/window_manager2/window_manager2.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/test_service/test_request_tracker.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/test_service/test_service.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/shell/app_child_process.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/shell/external_application_registrar.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/shell/external_service.mojom View 1 chunk +1 line, -3 lines 0 comments Download
D mojo/spy/PRESUBMIT.py View 1 chunk +0 lines, -40 lines 0 comments Download
M mojo/spy/public/spy.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M services/http_server/public/http_server.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M sky/services/inspector/inspector.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M sky/tools/debugger/debugger.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M sky/viewer/services/inspector.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M sky/viewer/services/tracing.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M sky/viewer/test_observer.mojom View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 1 month ago (2014-10-31 19:54:56 UTC) #1
jamesr
lgtm
6 years, 1 month ago (2014-10-31 19:58:56 UTC) #2
viettrungluu
6 years, 1 month ago (2014-10-31 20:00:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a08257c158b67dee27fba993b518fa67ff725a06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698