[android_webview] Don't call onPageFinished for history API.

[android_webview] Don't call onPageFinished for history API.

Turns out the refactoring in r158146 made us use the incorrect
WebContentsObserver callback.

BUG=https://code.google.com/p/android/issues/detail?id=62100, b/11656658 
TEST=AndroidWebViewTest

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235785

[mkosiba (inactive), 2013-11-15 17:06:37]

PTAL

[Kristian Monsen, 2013-11-15 21:56:43]

Is there a bug for this?

[joth, 2013-11-15 21:58:49]

On 2013/11/15 21:56:43, Kristian Monsen wrote:
> Is there a bug for this?

It's https://code.google.com/p/android/issues/detail?id=62100 (note android
rather than chromium project)

could put the full URL in the BUG= here?

[joth, 2013-11-15 22:01:44]

(although most the discussion actually happened on b/11656658. Yay for
three bug trackers!)



On 15 November 2013 13:58, <joth@chromium.org> wrote:

> On 2013/11/15 21:56:43, Kristian Monsen wrote:
>
>> Is there a bug for this?
>>
>
> It's https://code.google.com/p/android/issues/detail?id=62100 (note
> android
> rather than chromium project)
>
> could put the full URL in the BUG= here?
>
> https://codereview.chromium.org/68763012/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Kristian Monsen, 2013-11-15 22:08:03]

lgtm

[joth, 2013-11-15 22:28:50]

lgtm2

https://codereview.chromium.org/68763012/diff/180001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
(right):

https://codereview.chromium.org/68763012/diff/180001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java:144:
// a callback for the iframe.
smart! we could probably apply that pattern other places. (video requires user
gesture negative-test comes to mind)

[commit-bot: I haz the power, 2013-11-18 17:02:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/68763012/180001

[commit-bot: I haz the power, 2013-11-18 19:06:45]

Change committed as 235785