android_webview/java/src/org/chromium/android_webview/AwContentsClient.java - Issue 68763012: [android_webview] Don't call onPageFinished for history API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 68763012: [android_webview] Don't call onPageFinished for history API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

index 3baa7675715e13876fc60a1f6649bed488420b86..26f7c6d684593c66e77311578e72e1ed2724b807 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

@@ -58,8 +58,9 @@ public abstract class AwContentsClient {

}

@Override

- public void didStopLoading(String url) {

- AwContentsClient.this.onPageFinished(url);

+ public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame) {

+ if (isMainFrame)

+ AwContentsClient.this.onPageFinished(validatedUrl);

}

@Override