android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java - Issue 68763012: [android_webview] Don't call onPageFinished for history API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

Issue 68763012: [android_webview] Don't call onPageFinished for history API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java ('k') | content/browser/android/web_contents_observer_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

index 365645dc5481dc31d6f909c660080957e8ce6994..b2f510b36c5e6b3b3b4a9d55ef1afca5818a5eaf 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

@@ -214,6 +214,18 @@ public class LoadDataWithBaseUrlTest extends AwTestBase {

@SmallTest

@Feature({"AndroidWebView"})

+ public void testOnPageFinishedUrlIsBaseUrl() throws Throwable {

+ final String pageHtml = "<html><body>Hello, world!</body></html>";

+ final String baseUrl = "http://example.com/";

+ loadDataWithBaseUrlSync(pageHtml, "text/html", false, baseUrl, baseUrl);

+ TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHelper =

+ mContentsClient.getOnPageFinishedHelper();

+ assertEquals(baseUrl, onPageFinishedHelper.getUrl());

+ }

+ @SmallTest

+ @Feature({"AndroidWebView"})

public void testHistoryUrlIgnoredWithDataSchemeBaseUrl() throws Throwable {

final String pageHtml = "<html><body>bar</body></html>";

final String historyUrl = "http://history.com/";