Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 686863002: Revert "Revert of Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolve… (Closed)

Created:
6 years, 1 month ago by Alexander Alekseev
Modified:
6 years, 1 month ago
Reviewers:
CC:
chromium-reviews, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (patchset #1 id:1 of https://codereview.chromium.org/658903004/)" This re-applies https://codereview.chromium.org/620563002 again. Note to tree sheriffs: this CL might trigger ChromeOS telemetry tests failing with error messages like "Cannot set property 'disabled' of null". BUG=419030 TBR=nkostylev@chromium.org Committed: https://crrev.com/d7fb417c35f3f3f893531f4de15e50888446d9be Cr-Commit-Position: refs/heads/master@{#303655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -210 lines) Patch
M chrome/browser/chromeos/base/locale_util.h View 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/base/locale_util.cc View 6 chunks +27 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 3 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.h View 4 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 8 chunks +158 lines, -32 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 6 chunks +20 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 7 chunks +88 lines, -70 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686863002/1
6 years, 1 month ago (2014-11-11 15:17:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 16:04:06 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 16:04:46 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d7fb417c35f3f3f893531f4de15e50888446d9be
Cr-Commit-Position: refs/heads/master@{#303655}

Powered by Google App Engine
This is Rietveld 408576698