Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 620563002: ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (Closed)

Created:
6 years, 2 months ago by Alexander Alekseev
Modified:
6 years, 2 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. BUG=419030 Committed: https://crrev.com/d52dffddbf0abe5ca55509a9cdedcd9b0674bb1c Cr-Commit-Position: refs/heads/master@{#298860}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Update aftr review. #

Total comments: 14

Patch Set 3 : Cleanup. #

Total comments: 2

Patch Set 4 : Update after review. #

Total comments: 2

Patch Set 5 : Cleanup. #

Patch Set 6 : Rebased. #

Patch Set 7 : Fixed public user session. #

Patch Set 8 : Moved enable_layouts calculation to NetworkScreenHandler.' #

Total comments: 3

Patch Set 9 : Add DCHECK. #

Patch Set 10 : Add wait for button in TermsOfServiceWithLocaleSwitch. #

Patch Set 11 : Debug added. #

Patch Set 12 : More debug added. #

Patch Set 13 : Fixed tests. #

Patch Set 14 : Revert a change in NSH. #

Patch Set 15 : Debug added. #

Patch Set 16 : TermsOfService screen fixed. #

Patch Set 17 : Removed debug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+525 lines, -312 lines) Patch
M chrome/browser/chromeos/base/locale_util.h View 1 2 3 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/base/locale_util.cc View 1 2 3 6 chunks +27 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 3 4 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 4 5 3 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_localization_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +135 lines, -101 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 2 3 4 5 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 3 4 5 2 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.h View 1 2 3 4 5 6 7 4 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 8 chunks +154 lines, -32 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 1 2 3 4 5 6 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 2 3 4 5 6 7 13 7 chunks +87 lines, -70 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc View 1 2 3 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 37 (9 generated)
Alexander Alekseev
Please review.
6 years, 2 months ago (2014-09-30 17:28:20 UTC) #2
dzhioev (left Google)
https://codereview.chromium.org/620563002/diff/1/chrome/browser/ui/webui/chromeos/login/l10n_util.h File chrome/browser/ui/webui/chromeos/login/l10n_util.h (right): https://codereview.chromium.org/620563002/diff/1/chrome/browser/ui/webui/chromeos/login/l10n_util.h#newcode34 chrome/browser/ui/webui/chromeos/login/l10n_util.h:34: const std::string& language_directionality, You can calculate directionality inside of ...
6 years, 2 months ago (2014-10-01 15:08:08 UTC) #3
Alexander Alekseev
+nkostylev for chrome/browser/chromeos/base/ chrome/browser/chromeos/chrome_browser_main_chromeos.cc Please review. https://codereview.chromium.org/620563002/diff/1/chrome/browser/ui/webui/chromeos/login/l10n_util.h File chrome/browser/ui/webui/chromeos/login/l10n_util.h (right): https://codereview.chromium.org/620563002/diff/1/chrome/browser/ui/webui/chromeos/login/l10n_util.h#newcode34 chrome/browser/ui/webui/chromeos/login/l10n_util.h:34: const std::string& language_directionality, ...
6 years, 2 months ago (2014-10-02 13:12:07 UTC) #4
Nikita (slow)
lgtm https://codereview.chromium.org/620563002/diff/40001/chrome/browser/chromeos/base/locale_util.h File chrome/browser/chromeos/base/locale_util.h (right): https://codereview.chromium.org/620563002/diff/40001/chrome/browser/chromeos/base/locale_util.h#newcode24 chrome/browser/chromeos/base/locale_util.h:24: class LanguageSwitchResult { struct
6 years, 2 months ago (2014-10-02 13:47:29 UTC) #6
dzhioev (left Google)
https://codereview.chromium.org/620563002/diff/20001/chrome/browser/chromeos/base/locale_util.h File chrome/browser/chromeos/base/locale_util.h (right): https://codereview.chromium.org/620563002/diff/20001/chrome/browser/chromeos/base/locale_util.h#newcode37 chrome/browser/chromeos/base/locale_util.h:37: // Arguments: Update comment. https://codereview.chromium.org/620563002/diff/20001/chrome/browser/chromeos/base/locale_util.h#newcode42 chrome/browser/chromeos/base/locale_util.h:42: typedef base::Callback<void(scoped_ptr<LanguageSwitchResult> result)> ...
6 years, 2 months ago (2014-10-02 14:12:10 UTC) #7
Alexander Alekseev
https://codereview.chromium.org/620563002/diff/20001/chrome/browser/chromeos/base/locale_util.h File chrome/browser/chromeos/base/locale_util.h (right): https://codereview.chromium.org/620563002/diff/20001/chrome/browser/chromeos/base/locale_util.h#newcode37 chrome/browser/chromeos/base/locale_util.h:37: // Arguments: On 2014/10/02 14:12:10, dzhioev wrote: > Update ...
6 years, 2 months ago (2014-10-02 19:05:04 UTC) #8
dzhioev (left Google)
LTGM with nit https://codereview.chromium.org/620563002/diff/60001/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc (right): https://codereview.chromium.org/620563002/diff/60001/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc#newcode259 chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc:259: new locale_util::LanguageSwitchResult(result)).Pass()); nit: Is 'Pass' needed ...
6 years, 2 months ago (2014-10-02 20:14:29 UTC) #9
dzhioev (left Google)
LGTM =) On Fri Oct 03 2014 at 12:14:30 AM <dzhioev@chromium.org> wrote: > LTGM with ...
6 years, 2 months ago (2014-10-02 20:32:30 UTC) #10
dzhioev (left Google)
On 2014/10/02 20:32:30, dzhioev wrote: > LGTM =) > > On Fri Oct 03 2014 ...
6 years, 2 months ago (2014-10-02 20:33:21 UTC) #11
Alexander Alekseev
https://codereview.chromium.org/620563002/diff/60001/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc (right): https://codereview.chromium.org/620563002/diff/60001/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc#newcode259 chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc:259: new locale_util::LanguageSwitchResult(result)).Pass()); On 2014/10/02 20:14:29, dzhioev wrote: > nit: ...
6 years, 2 months ago (2014-10-02 21:06:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620563002/80001
6 years, 2 months ago (2014-10-02 21:08:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/20302)
6 years, 2 months ago (2014-10-02 22:25:18 UTC) #16
Alexander Alekseev
I needed to fix public user session. PTAL at chrome/browser/ui/webui/chromeos/login/l10n_util.cc
6 years, 2 months ago (2014-10-06 17:29:50 UTC) #17
Alexander Alekseev
I've moved calculation of "should enable login layouts" to NetworkScreenHandler.
6 years, 2 months ago (2014-10-06 18:20:54 UTC) #18
Nikita (slow)
lgtm, thanks! https://codereview.chromium.org/620563002/diff/140001/chrome/browser/ui/webui/chromeos/login/l10n_util.cc File chrome/browser/ui/webui/chromeos/login/l10n_util.cc (right): https://codereview.chromium.org/620563002/diff/140001/chrome/browser/ui/webui/chromeos/login/l10n_util.cc#newcode533 chrome/browser/ui/webui/chromeos/login/l10n_util.cc:533: manager->GetActiveIMEState()->EnableLoginLayouts( nit: Add DCHECK(ProfileHelper::IsSigninProfile(ProfileManager::GetActiveUserProfile()))
6 years, 2 months ago (2014-10-06 18:46:39 UTC) #19
Alexander Alekseev
https://codereview.chromium.org/620563002/diff/140001/chrome/browser/ui/webui/chromeos/login/l10n_util.cc File chrome/browser/ui/webui/chromeos/login/l10n_util.cc (right): https://codereview.chromium.org/620563002/diff/140001/chrome/browser/ui/webui/chromeos/login/l10n_util.cc#newcode533 chrome/browser/ui/webui/chromeos/login/l10n_util.cc:533: manager->GetActiveIMEState()->EnableLoginLayouts( On 2014/10/06 18:46:39, Nikita Kostylev wrote: > nit: ...
6 years, 2 months ago (2014-10-06 18:57:26 UTC) #20
Nikita (slow)
https://codereview.chromium.org/620563002/diff/140001/chrome/browser/ui/webui/chromeos/login/l10n_util.cc File chrome/browser/ui/webui/chromeos/login/l10n_util.cc (right): https://codereview.chromium.org/620563002/diff/140001/chrome/browser/ui/webui/chromeos/login/l10n_util.cc#newcode533 chrome/browser/ui/webui/chromeos/login/l10n_util.cc:533: manager->GetActiveIMEState()->EnableLoginLayouts( On 2014/10/06 18:57:26, Alexander Alekseev wrote: > On ...
6 years, 2 months ago (2014-10-06 19:11:37 UTC) #21
Alexander Alekseev
+bartfab for oobe_screen_terms_of_service.js Please review.
6 years, 2 months ago (2014-10-08 18:05:43 UTC) #22
Alexander Alekseev
On 2014/10/08 18:05:43, Alexander Alekseev wrote: > +bartfab for oobe_screen_terms_of_service.js > > Please review. -bartfab
6 years, 2 months ago (2014-10-08 18:10:27 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620563002/320001
6 years, 2 months ago (2014-10-08 18:11:31 UTC) #25
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-08 20:30:18 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620563002/320001
6 years, 2 months ago (2014-10-08 20:43:19 UTC) #29
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-09 02:24:27 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/620563002/320001
6 years, 2 months ago (2014-10-09 13:07:41 UTC) #33
commit-bot: I haz the power
Committed patchset #17 (id:320001) as 42f6a2a3876c8be27d35d1233feecca14379a73b
6 years, 2 months ago (2014-10-09 13:17:21 UTC) #34
commit-bot: I haz the power
Patchset 17 (id:??) landed as https://crrev.com/d52dffddbf0abe5ca55509a9cdedcd9b0674bb1c Cr-Commit-Position: refs/heads/master@{#298860}
6 years, 2 months ago (2014-10-09 13:18:50 UTC) #35
achuithb
On 2014/10/09 13:18:50, I haz the power (commit-bot) wrote: > Patchset 17 (id:??) landed as ...
6 years, 2 months ago (2014-10-14 09:16:54 UTC) #36
achuithb
6 years, 2 months ago (2014-10-14 09:17:36 UTC) #37
Message was sent while issue was closed. 
A revert of this CL (patchset #17 id:320001) has been created in
https://codereview.chromium.org/653723004/ by achuith@chromium.org.

The reason for reverting is: Speculatively reverting for
https://crbug.com/422703.

Powered by Google App Engine
This is Rietveld 408576698