Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 686653002: Remove a bunch of fixed position dead code. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove a bunch of fixed position dead code. There is not change in behavior here. Just removing dead code now that we no longer support position:fixed. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cdd2a4b576ec452f9748191d871f6c416ed93637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -398 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Range.h View 1 chunk +2 lines, -8 lines 0 comments Download
M sky/engine/core/dom/Range.cpp View 3 chunks +4 lines, -22 lines 0 comments Download
D sky/engine/core/page/scrolling/ScrollingConstraints.h View 1 chunk +0 lines, -115 lines 0 comments Download
D sky/engine/core/page/scrolling/ScrollingConstraints.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +0 lines, -28 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 4 chunks +4 lines, -25 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderInline.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 4 chunks +11 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderText.h View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderText.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/public/platform/WebLayer.h View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/engine/public/platform/WebLayerPositionConstraint.h View 1 chunk +0 lines, -55 lines 0 comments Download
M sky/viewer/cc/web_layer_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/viewer/cc/web_layer_impl.cc View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-10-28 03:41:21 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-28 03:47:47 UTC) #3
ojan
6 years, 1 month ago (2014-10-28 16:34:23 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cdd2a4b576ec452f9748191d871f6c416ed93637.

Powered by Google App Engine
This is Rietveld 408576698