Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: sky/engine/core/rendering/RenderBox.h

Issue 686653002: Remove a bunch of fixed position dead code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 // formula for computing a collapsed margin is |maxPosMargin| - |maxNegmargi n|. 326 // formula for computing a collapsed margin is |maxPosMargin| - |maxNegmargi n|.
327 // For a non-collapsing box, such as a leaf element, this formula will simpl y return 327 // For a non-collapsing box, such as a leaf element, this formula will simpl y return
328 // the margin of the element. Blocks override the maxMarginBefore and maxMa rginAfter 328 // the margin of the element. Blocks override the maxMarginBefore and maxMa rginAfter
329 // methods. 329 // methods.
330 enum MarginSign { PositiveMargin, NegativeMargin }; 330 enum MarginSign { PositiveMargin, NegativeMargin };
331 virtual bool isSelfCollapsingBlock() const { return false; } 331 virtual bool isSelfCollapsingBlock() const { return false; }
332 virtual LayoutUnit collapsedMarginBefore() const { return marginBefore(); } 332 virtual LayoutUnit collapsedMarginBefore() const { return marginBefore(); }
333 virtual LayoutUnit collapsedMarginAfter() const { return marginAfter(); } 333 virtual LayoutUnit collapsedMarginAfter() const { return marginAfter(); }
334 334
335 virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedO ffset) const override; 335 virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedO ffset) const override;
336 virtual void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const overrid e; 336 virtual void absoluteQuads(Vector<FloatQuad>&) const override;
337 337
338 virtual void layout() override; 338 virtual void layout() override;
339 virtual void paint(PaintInfo&, const LayoutPoint&) override; 339 virtual void paint(PaintInfo&, const LayoutPoint&) override;
340 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) override; 340 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) override;
341 341
342 virtual LayoutUnit minPreferredLogicalWidth() const override; 342 virtual LayoutUnit minPreferredLogicalWidth() const override;
343 virtual LayoutUnit maxPreferredLogicalWidth() const override; 343 virtual LayoutUnit maxPreferredLogicalWidth() const override;
344 344
345 // FIXME: We should rename these back to overrideLogicalHeight/Width and hav e them store 345 // FIXME: We should rename these back to overrideLogicalHeight/Width and hav e them store
346 // the border-box height/width like the regular height/width accessors on Re nderBox. 346 // the border-box height/width like the regular height/width accessors on Re nderBox.
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
638 BackgroundBleedAvoidance determineBackgroundBleedAvoidance(GraphicsContext*, const BoxDecorationData&) const; 638 BackgroundBleedAvoidance determineBackgroundBleedAvoidance(GraphicsContext*, const BoxDecorationData&) const;
639 bool backgroundHasOpaqueTopLayer() const; 639 bool backgroundHasOpaqueTopLayer() const;
640 640
641 void computePositionedLogicalWidth(LogicalExtentComputedValues&) const; 641 void computePositionedLogicalWidth(LogicalExtentComputedValues&) const;
642 642
643 LayoutUnit computeIntrinsicLogicalWidthUsing(const Length& logicalWidthLengt h, LayoutUnit availableLogicalWidth, LayoutUnit borderAndPadding) const; 643 LayoutUnit computeIntrinsicLogicalWidthUsing(const Length& logicalWidthLengt h, LayoutUnit availableLogicalWidth, LayoutUnit borderAndPadding) const;
644 LayoutUnit computeIntrinsicLogicalContentHeightUsing(const Length& logicalHe ightLength, LayoutUnit intrinsicContentHeight, LayoutUnit borderAndPadding) cons t; 644 LayoutUnit computeIntrinsicLogicalContentHeightUsing(const Length& logicalHe ightLength, LayoutUnit intrinsicContentHeight, LayoutUnit borderAndPadding) cons t;
645 645
646 virtual bool shouldComputeSizeAsReplaced() const { return isReplaced() && !i sInlineBlock(); } 646 virtual bool shouldComputeSizeAsReplaced() const { return isReplaced() && !i sInlineBlock(); }
647 647
648 virtual void mapLocalToContainer(const RenderLayerModelObject* paintInvalida tionContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = 0, const PaintInvalidationState* = 0) const override; 648 virtual void mapLocalToContainer(const RenderLayerModelObject* paintInvalida tionContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, const PaintInvalidationState* = 0) const override;
649 virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) c onst override;
650 649
651 void paintRootBoxFillLayers(const PaintInfo&); 650 void paintRootBoxFillLayers(const PaintInfo&);
652 651
653 RenderObject* splitAnonymousBoxesAroundChild(RenderObject* beforeChild); 652 RenderObject* splitAnonymousBoxesAroundChild(RenderObject* beforeChild);
654 653
655 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer* cur rentCompositedLayer, const LayoutPoint& layerOffset, const LayoutRect& container Rect) const override; 654 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer* cur rentCompositedLayer, const LayoutPoint& layerOffset, const LayoutRect& container Rect) const override;
656 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const override; 655 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const override;
657 656
658 void updateIntrinsicContentLogicalHeight(LayoutUnit intrinsicContentLogicalH eight) const { m_intrinsicContentLogicalHeight = intrinsicContentLogicalHeight; } 657 void updateIntrinsicContentLogicalHeight(LayoutUnit intrinsicContentLogicalH eight) const { m_intrinsicContentLogicalHeight = intrinsicContentLogicalHeight; }
659 658
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
784 if (UNLIKELY(inlineBoxWrapper() != 0)) 783 if (UNLIKELY(inlineBoxWrapper() != 0))
785 deleteLineBoxWrapper(); 784 deleteLineBoxWrapper();
786 } 785 }
787 786
788 ensureRareData().m_inlineBoxWrapper = boxWrapper; 787 ensureRareData().m_inlineBoxWrapper = boxWrapper;
789 } 788 }
790 789
791 } // namespace blink 790 } // namespace blink
792 791
793 #endif // RenderBox_h 792 #endif // RenderBox_h
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698