Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: content/public/common/push_messaging_status.h

Issue 686133003: Reject push registrations when no sender Id has been provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/push_messaging_status.h
diff --git a/content/public/common/push_messaging_status.h b/content/public/common/push_messaging_status.h
index 845741f3260206b8468742d726d463089111cc2b..ec608584f91345cf140cc5f84a48501fba3d3321 100644
--- a/content/public/common/push_messaging_status.h
+++ b/content/public/common/push_messaging_status.h
@@ -28,13 +28,16 @@ enum PushRegistrationStatus {
// Registration failed in the push service implemented by the embedder.
PUSH_REGISTRATION_STATUS_SERVICE_ERROR = 5,
+ // Registration failed because no sender Id was provided by the page.
Michael van Ouwerkerk 2014/10/29 13:53:18 nit: s/Id/id/
Peter Beverloo 2014/10/29 13:56:23 Done.
+ PUSH_REGISTRATION_STATUS_NO_SENDER_ID = 6,
+
// NOTE: Do not renumber these as that would confuse interpretation of
// previously logged data. When making changes, also update the enum list
// in tools/metrics/histograms/histograms.xml to keep it in sync, and
// update PUSH_REGISTRATION_STATUS_LAST below.
// Used for IPC message range checks.
- PUSH_REGISTRATION_STATUS_LAST = PUSH_REGISTRATION_STATUS_SERVICE_ERROR
+ PUSH_REGISTRATION_STATUS_LAST = PUSH_REGISTRATION_STATUS_NO_SENDER_ID
};
// Push message delivery success / error codes for internal use.

Powered by Google App Engine
This is Rietveld 408576698