Reject push registrations when no sender Id has been provided.

content/public/common/push_messaging_status.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_PUSH_MESSAGING_STATUS_H_
 #define CONTENT_PUBLIC_COMMON_PUSH_MESSAGING_STATUS_H_
 
 namespace content {
 
 // Push registration success / error codes for internal use & reporting in UMA.
@@ skipping 10 matching lines @@
   // Registration failed because the maximum number of registratons has been
   // reached.
   PUSH_REGISTRATION_STATUS_LIMIT_REACHED = 3,
 
   // Registration failed because permission was denied.
   PUSH_REGISTRATION_STATUS_PERMISSION_DENIED = 4,
 
   // Registration failed in the push service implemented by the embedder.
   PUSH_REGISTRATION_STATUS_SERVICE_ERROR = 5,
 
+  // Registration failed because no sender Id was provided by the page.

[Michael van Ouwerkerk, 2014/10/29 13:53:18]

nit: s/Id/id/

[Peter Beverloo, 2014/10/29 13:56:23]

Done.

+  PUSH_REGISTRATION_STATUS_NO_SENDER_ID = 6,
+
   // NOTE: Do not renumber these as that would confuse interpretation of
   // previously logged data. When making changes, also update the enum list
   // in tools/metrics/histograms/histograms.xml to keep it in sync, and
   // update PUSH_REGISTRATION_STATUS_LAST below.
 
   // Used for IPC message range checks.
-  PUSH_REGISTRATION_STATUS_LAST = PUSH_REGISTRATION_STATUS_SERVICE_ERROR
+  PUSH_REGISTRATION_STATUS_LAST = PUSH_REGISTRATION_STATUS_NO_SENDER_ID
 };
 
 // Push message delivery success / error codes for internal use.
 enum PushDeliveryStatus {
   // The message was successfully delivered.
   PUSH_DELIVERY_STATUS_SUCCESS,
 
   // The message could not be delivered because no service worker was found.
   PUSH_DELIVERY_STATUS_NO_SERVICE_WORKER,
 
   // The message could not be delivered because of a service worker error.
   PUSH_DELIVERY_STATUS_SERVICE_WORKER_ERROR,
 
   // When making changes, update PUSH_DELIVERY_STATUS_LAST below.
 
   // Used for IPC message range checks.
   PUSH_DELIVERY_STATUS_LAST = PUSH_DELIVERY_STATUS_SERVICE_WORKER_ERROR
 };
 
 const char* PushRegistrationStatusToString(PushRegistrationStatus status);
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_PUSH_MESSAGING_STATUS_H_