content/public/common/push_messaging_status.cc - Issue 686133003: Reject push registrations when no sender Id has been provided.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/push_messaging_status.cc

Issue 686133003: Reject push registrations when no sender Id has been provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/push_messaging_status.h ('K') | « content/public/common/push_messaging_status.h ('k') | content/renderer/push_messaging_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/push_messaging_status.cc

diff --git a/content/public/common/push_messaging_status.cc b/content/public/common/push_messaging_status.cc

index 7c476408d6ea8b6c6949e01051198f8703973f81..d3b3d1b9dc51f2b95da738141b17277caf961aa6 100644

--- a/content/public/common/push_messaging_status.cc

+++ b/content/public/common/push_messaging_status.cc

@@ -27,6 +27,9 @@ const char* PushRegistrationStatusToString(PushRegistrationStatus status) {

case PUSH_REGISTRATION_STATUS_SERVICE_ERROR:

return "Registration failed - push service error";

+ case PUSH_REGISTRATION_STATUS_NO_SENDER_ID:

+ return "Registration failed - no sender id provided";

}

NOTREACHED();

return "";