Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 685593006: This CL provides a bunch of new parser tests, and updates the (Closed)

Created:
6 years, 1 month ago by Hixie
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

This CL provides a bunch of new parser tests, and updates the TestExpectations file to skip the ones that fail or crash. It also updates the TestExpectations parser to support URLs pointing to the mojo repo's issue tracker. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5b16e5567ecb3296660577f989d6afb12183793b

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -1 line) Patch
M sky/tests/TestExpectations View 1 chunk +11 lines, -0 lines 0 comments Download
A sky/tests/parser/README.md View 1 1 chunk +133 lines, -0 lines 0 comments Download
A sky/tests/parser/control.sky View 1 chunk +7 lines, -0 lines 0 comments Download
A sky/tests/parser/control-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A sky/tests/parser/cr.sky View 1 chunk +1 line, -0 lines 0 comments Download
A + sky/tests/parser/cr-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/tests/parser/empty.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/tests/parser/empty-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/tests/parser/endtag.sky View 1 chunk +10 lines, -0 lines 0 comments Download
A sky/tests/parser/endtag-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A sky/tests/parser/html.sky View 1 chunk +23 lines, -0 lines 0 comments Download
A sky/tests/parser/html-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A sky/tests/parser/normaliser-crlf.sky View 1 chunk +19 lines, -0 lines 0 comments Download
A sky/tests/parser/normaliser-crlf-expected.txt View 1 chunk +25 lines, -0 lines 0 comments Download
A sky/tests/parser/normaliser-null.sky View Binary file 0 comments Download
A sky/tests/parser/normaliser-null-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A sky/tests/parser/script.sky View 1 chunk +44 lines, -0 lines 0 comments Download
A sky/tests/parser/script-expected.txt View 1 chunk +57 lines, -0 lines 0 comments Download
A sky/tests/parser/starttag.sky View 1 chunk +77 lines, -0 lines 0 comments Download
A sky/tests/parser/starttag-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A sky/tests/parser/style.sky View 1 chunk +56 lines, -0 lines 0 comments Download
A sky/tests/parser/style-expected.txt View 1 chunk +55 lines, -0 lines 0 comments Download
A sky/tests/parser/utf16.sky View Binary file 0 comments Download
A + sky/tests/parser/utf16-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/tests/parser/voidtag.sky View 1 chunk +22 lines, -0 lines 0 comments Download
A sky/tests/parser/voidtag-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/models/test_expectations.py View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
lgtm https://codereview.chromium.org/685593006/diff/1/sky/tests/TestExpectations File sky/tests/TestExpectations (right): https://codereview.chromium.org/685593006/diff/1/sky/tests/TestExpectations#newcode15 sky/tests/TestExpectations:15: #https://github.com/domokit/mojo/issues/15 parser/utf16.sky [ Skip ] Why is this ...
6 years, 1 month ago (2014-10-29 01:00:54 UTC) #2
Hixie
On 2014/10/29 01:00:54, abarth wrote: > > https://codereview.chromium.org/685593006/diff/1/sky/tests/TestExpectations#newcode15 > sky/tests/TestExpectations:15: #https://github.com/domokit/mojo/issues/15 > parser/utf16.sky [ Skip ...
6 years, 1 month ago (2014-10-29 01:56:50 UTC) #3
Hixie
6 years, 1 month ago (2014-10-29 01:58:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5b16e5567ecb3296660577f989d6afb12183793b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698