Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(558)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: sky/tests/parser/README.md
Issue
685593006
:
This CL provides a bunch of new parser tests, and updates the (Closed)
Base URL: https://github.com/domokit/mojo.git@master
Patch Set:
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
sky/tests/TestExpectations
sky/tests/parser/README.md
sky/tests/parser/control.sky
sky/tests/parser/control-expected.txt
sky/tests/parser/cr.sky
sky/tests/parser/cr-expected.txt
sky/tests/parser/empty.sky
sky/tests/parser/empty-expected.txt
sky/tests/parser/endtag.sky
sky/tests/parser/endtag-expected.txt
sky/tests/parser/html.sky
sky/tests/parser/html-expected.txt
sky/tests/parser/normaliser-crlf.sky
sky/tests/parser/normaliser-crlf-expected.txt
sky/tests/parser/normaliser-null.sky
sky/tests/parser/normaliser-null-expected.txt
sky/tests/parser/script.sky
sky/tests/parser/script-expected.txt
sky/tests/parser/starttag.sky
sky/tests/parser/starttag-expected.txt
sky/tests/parser/style.sky
sky/tests/parser/style-expected.txt
sky/tests/parser/utf16.sky
sky/tests/parser/utf16-expected.txt
sky/tests/parser/voidtag.sky
sky/tests/parser/voidtag-expected.txt
sky/tools/webkitpy/layout_tests/models/test_expectations.py
View unified diff
|
Download patch
« no previous file with comments
|
« sky/tests/TestExpectations
('k') |
sky/tests/parser/control.sky »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
The empty, cr, and utf16 tests don't import the test framework so they
2
currently hang until timeout. Really they should just check that
3
nothing crashes. For now they are disabled.
4
5
We should also test the following (each line is its own test):
6
7
```
8
<
9
<!
10
<!-
11
<!--
12
<!---
13
<!----
14
<!---->
15
<!----->
16
<a
17
<aa
18
<a
19
<a a
20
<a a=
21
<a a=&
22
<a a=&#
23
<a a=&#x
24
<a a=
25
<a a=
26
<a a=
27
<a a=
28
<a a=&a
29
<a a=&a;
30
<a a=&;
31
<a a='
32
<a a="
33
<a a=a
34
<a>
35
<a >
36
<a a>
37
<a a=>
38
<a a=&>
39
<a a=&#>
40
<a a=&#x>
41
<a a=>
42
<a a=>
43
<a a=>
44
<a a=>
45
<a a=&a>
46
<a a=&a;>
47
<a a=&;>
48
<a a=''>
49
<a a="">
50
<a a=a>
51
<a a >
52
<a a= >
53
<a a=& >
54
<a a=&# >
55
<a a=&#x >
56
<a a= >
57
<a a= >
58
<a a= >
59
<a a= >
60
<a a=&a >
61
<a a=&a; >
62
<a a=&; >
63
<a a='' >
64
<a a="" >
65
<a a=a >
66
</a
67
</aa
68
</a
69
</a a
70
</a a=
71
</a a=&
72
</a a=&#
73
</a a=&#x
74
</a a=
75
</a a=
76
</a a=
77
</a a=
78
</a a=&a
79
</a a=&a;
80
</a a=&;
81
</a a='
82
</a a="
83
</a a=a
84
</a>
85
</a >
86
</a a>
87
</a a=>
88
</a a=&>
89
</a a=&#>
90
</a a=&#x>
91
</a a=>
92
</a a=>
93
</a a=>
94
</a a=>
95
</a a=&a>
96
</a a=&a;>
97
</a a=&;>
98
</a a=''>
99
</a a="">
100
</a a=a>
101
</a a >
102
</a a= >
103
</a a=& >
104
</a a=&# >
105
</a a=&#x >
106
</a a= >
107
</a a= >
108
</a a= >
109
</a a= >
110
</a a=&a >
111
</a a=&a; >
112
</a a=&; >
113
</a a='' >
114
</a a="" >
115
</a a=a >
116
a
117
&
118
&#
119
&#x
120

121

122

123

124
&a
125
&a;
126
&;
127
```
128
129
We should also test:
130
131
- multiple elements per page
132
- signature stuff
133
- <t>
OLD
NEW
« no previous file with comments
|
« sky/tests/TestExpectations
('k') |
sky/tests/parser/control.sky »
('j') |
no next file with comments »
Issue 685593006: This CL provides a bunch of new parser tests, and updates the (Closed)
Created 6 years, 1 month ago by Hixie
Modified 6 years, 1 month ago
Reviewers: abarth-chromium
Base URL: https://github.com/domokit/mojo.git@master
Comments: 2
This is Rietveld
408576698