Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: sky/tools/webkitpy/layout_tests/models/test_expectations.py

Issue 685593006: This CL provides a bunch of new parser tests, and updates the (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tests/parser/voidtag-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/webkitpy/layout_tests/models/test_expectations.py
diff --git a/sky/tools/webkitpy/layout_tests/models/test_expectations.py b/sky/tools/webkitpy/layout_tests/models/test_expectations.py
index d2d7da8d3681cf5cdf39b5d118c4229b5deb2b47..19a9f7385f18f26faa7e4060a9468d4999c35c35 100644
--- a/sky/tools/webkitpy/layout_tests/models/test_expectations.py
+++ b/sky/tools/webkitpy/layout_tests/models/test_expectations.py
@@ -51,6 +51,7 @@ BASELINE_SUFFIX_LIST = ('png', 'wav', 'txt')
WEBKIT_BUG_PREFIX = 'webkit.org/b/'
CHROMIUM_BUG_PREFIX = 'crbug.com/'
V8_BUG_PREFIX = 'code.google.com/p/v8/issues/detail?id='
+MOJO_BUG_PREFIX = 'https://github.com/domokit/mojo/issues/'
NAMED_BUG_PREFIX = 'Bug('
MISSING_KEYWORD = 'Missing'
@@ -284,15 +285,15 @@ class TestExpectationParser(object):
if (token.startswith(WEBKIT_BUG_PREFIX) or
token.startswith(CHROMIUM_BUG_PREFIX) or
token.startswith(V8_BUG_PREFIX) or
+ token.startswith(MOJO_BUG_PREFIX) or
token.startswith(NAMED_BUG_PREFIX)):
if state != 'start':
warnings.append('"%s" is not at the start of the line.' % token)
break
- if token.startswith(WEBKIT_BUG_PREFIX):
- bugs.append(token)
- elif token.startswith(CHROMIUM_BUG_PREFIX):
- bugs.append(token)
- elif token.startswith(V8_BUG_PREFIX):
+ if (token.startswith(WEBKIT_BUG_PREFIX) or
+ token.startswith(CHROMIUM_BUG_PREFIX) or
+ token.startswith(MOJO_BUG_PREFIX) or
+ token.startswith(V8_BUG_PREFIX)):
bugs.append(token)
else:
match = re.match('Bug\((\w+)\)$', token)
« no previous file with comments | « sky/tests/parser/voidtag-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698