Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: Source/bindings/core/v8/V8ValueCache.cpp

Issue 684803002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8ValueCache.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8ValueCache.cpp
diff --git a/Source/bindings/core/v8/V8ValueCache.cpp b/Source/bindings/core/v8/V8ValueCache.cpp
index 9c52a4124321c986af0bb54d5ea9ca5e3458b01e..9e8f615e9ce185810b602c6e9443e6a6ee8f3afb 100644
--- a/Source/bindings/core/v8/V8ValueCache.cpp
+++ b/Source/bindings/core/v8/V8ValueCache.cpp
@@ -71,7 +71,7 @@ static v8::Local<v8::String> makeExternalString(const String& string, v8::Isolat
return newString;
}
-v8::Handle<v8::String> StringCache::v8ExternalStringSlow(StringImpl* stringImpl, v8::Isolate* isolate)
+v8::Handle<v8::String> StringCache::v8ExternalStringSlow(v8::Isolate* isolate, StringImpl* stringImpl)
{
if (!stringImpl->length())
return v8::String::Empty(isolate);
@@ -83,7 +83,7 @@ v8::Handle<v8::String> StringCache::v8ExternalStringSlow(StringImpl* stringImpl,
return m_lastV8String.NewLocal(isolate);
}
- return createStringAndInsertIntoCache(stringImpl, isolate);
+ return createStringAndInsertIntoCache(isolate, stringImpl);
}
void StringCache::setReturnValueFromStringSlow(v8::ReturnValue<v8::Value> returnValue, StringImpl* stringImpl)
@@ -101,10 +101,10 @@ void StringCache::setReturnValueFromStringSlow(v8::ReturnValue<v8::Value> return
return;
}
- returnValue.Set(createStringAndInsertIntoCache(stringImpl, returnValue.GetIsolate()));
+ returnValue.Set(createStringAndInsertIntoCache(returnValue.GetIsolate(), stringImpl));
}
-v8::Local<v8::String> StringCache::createStringAndInsertIntoCache(StringImpl* stringImpl, v8::Isolate* isolate)
+v8::Local<v8::String> StringCache::createStringAndInsertIntoCache(v8::Isolate* isolate, StringImpl* stringImpl)
{
ASSERT(!m_stringCache.Contains(stringImpl));
ASSERT(stringImpl->length());
« no previous file with comments | « Source/bindings/core/v8/V8ValueCache.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698