Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: Source/bindings/core/v8/V8ValueCache.h

Issue 684803002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8ValueCache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8ValueCache.h
diff --git a/Source/bindings/core/v8/V8ValueCache.h b/Source/bindings/core/v8/V8ValueCache.h
index 3cb2deac0ebedf1929a155305874948a9766dd62..ec7816d519c4c42e469d2370da64653e9851d555 100644
--- a/Source/bindings/core/v8/V8ValueCache.h
+++ b/Source/bindings/core/v8/V8ValueCache.h
@@ -68,7 +68,7 @@ public:
ASSERT(stringImpl);
if (m_lastStringImpl.get() == stringImpl)
return m_lastV8String.NewLocal(isolate);
- return v8ExternalStringSlow(stringImpl, isolate);
+ return v8ExternalStringSlow(isolate, stringImpl);
}
void setReturnValueFromString(v8::ReturnValue<v8::Value> returnValue, StringImpl* stringImpl)
@@ -83,9 +83,9 @@ public:
friend class StringCacheMapTraits;
private:
- v8::Handle<v8::String> v8ExternalStringSlow(StringImpl*, v8::Isolate*);
+ v8::Handle<v8::String> v8ExternalStringSlow(v8::Isolate*, StringImpl*);
void setReturnValueFromStringSlow(v8::ReturnValue<v8::Value>, StringImpl*);
- v8::Local<v8::String> createStringAndInsertIntoCache(StringImpl*, v8::Isolate*);
+ v8::Local<v8::String> createStringAndInsertIntoCache(v8::Isolate*, StringImpl*);
void InvalidateLastString();
StringCacheMapTraits::MapType m_stringCache;
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8ValueCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698