Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Source/bindings/core/v8/V8ValueCache.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 53 matching lines @@
         return newString;
     }
 
     WebCoreStringResource16* stringResource = new WebCoreStringResource16(string);
     v8::Local<v8::String> newString = v8::String::NewExternal(isolate, stringResource);
     if (newString.IsEmpty())
         delete stringResource;
     return newString;
 }
 
-v8::Handle<v8::String> StringCache::v8ExternalStringSlow(StringImpl* stringImpl, v8::Isolate* isolate)
+v8::Handle<v8::String> StringCache::v8ExternalStringSlow(v8::Isolate* isolate, StringImpl* stringImpl)
 {
     if (!stringImpl->length())
         return v8::String::Empty(isolate);
 
     StringCacheMapTraits::MapType::PersistentValueReference cachedV8String = m_stringCache.GetReference(stringImpl);
     if (!cachedV8String.IsEmpty()) {
         m_lastStringImpl = stringImpl;
         m_lastV8String = cachedV8String;
         return m_lastV8String.NewLocal(isolate);
     }
 
-    return createStringAndInsertIntoCache(stringImpl, isolate);
+    return createStringAndInsertIntoCache(isolate, stringImpl);
 }
 
 void StringCache::setReturnValueFromStringSlow(v8::ReturnValue<v8::Value> returnValue, StringImpl* stringImpl)
 {
     if (!stringImpl->length()) {
         returnValue.SetEmptyString();
         return;
     }
 
     StringCacheMapTraits::MapType::PersistentValueReference cachedV8String = m_stringCache.GetReference(stringImpl);
     if (!cachedV8String.IsEmpty()) {
         m_lastStringImpl = stringImpl;
         m_lastV8String = cachedV8String;
         m_lastV8String.SetReturnValue(returnValue);
         return;
     }
 
-    returnValue.Set(createStringAndInsertIntoCache(stringImpl, returnValue.GetIsolate()));
+    returnValue.Set(createStringAndInsertIntoCache(returnValue.GetIsolate(), stringImpl));
 }
 
-v8::Local<v8::String> StringCache::createStringAndInsertIntoCache(StringImpl* stringImpl, v8::Isolate* isolate)
+v8::Local<v8::String> StringCache::createStringAndInsertIntoCache(v8::Isolate* isolate, StringImpl* stringImpl)
 {
     ASSERT(!m_stringCache.Contains(stringImpl));
     ASSERT(stringImpl->length());
 
     v8::Local<v8::String> newString = makeExternalString(String(stringImpl), isolate);
     if (newString.IsEmpty())
         return newString;
 
     v8::UniquePersistent<v8::String> wrapper(isolate, newString);
 
     stringImpl->ref();
     wrapper.MarkIndependent();
     m_stringCache.Set(stringImpl, wrapper.Pass(), &m_lastV8String);
     m_lastStringImpl = stringImpl;
 
     return newString;
 }
 
 void StringCache::InvalidateLastString()
 {
     m_lastStringImpl = nullptr;
     m_lastV8String.Reset();
 }
 
 } // namespace blink