Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 684683003: Referrer Policy: Add a flag to reduce `referer` granularity by default. (Closed)

Created:
6 years, 1 month ago by Mike West
Modified:
6 years, 1 month ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@default
Project:
blink
Visibility:
Public.

Description

Referrer Policy: Add a flag to reduce `referer` granularity by default. [1/2] If a site hasn't set an explicit referrer policy, this runtime-enabled flag will strip the outgoing header down to an origin. Perhaps this is a direction we could offer as a choice to users in the future? (Note that this implementation does not yet effect reditects. That's something to fix later if/when we want to look more closely at this kind of approach. Nothing worth doing for a strawman...). Adding this flag to help evaluate the impact such a change might have. [1/2] Blink: This patch. [2/2] Chromium: https://codereview.chromium.org/711033002 BUG=431711 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185057

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/weborigin/SecurityPolicy.cpp View 2 chunks +13 lines, -1 line 3 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mike West
Does this seem like a reasonable approach to what we discussed? -mike
6 years, 1 month ago (2014-11-10 13:57:42 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/684683003/diff/1/Source/platform/weborigin/SecurityPolicy.cpp File Source/platform/weborigin/SecurityPolicy.cpp (right): https://codereview.chromium.org/684683003/diff/1/Source/platform/weborigin/SecurityPolicy.cpp#newcode99 Source/platform/weborigin/SecurityPolicy.cpp:99: return Referrer(shouldHideReferrer(url, referrer) ? String() : origin + ...
6 years, 1 month ago (2014-11-10 14:53:19 UTC) #3
Mike West
Thanks! https://codereview.chromium.org/684683003/diff/1/Source/platform/weborigin/SecurityPolicy.cpp File Source/platform/weborigin/SecurityPolicy.cpp (right): https://codereview.chromium.org/684683003/diff/1/Source/platform/weborigin/SecurityPolicy.cpp#newcode99 Source/platform/weborigin/SecurityPolicy.cpp:99: return Referrer(shouldHideReferrer(url, referrer) ? String() : origin + ...
6 years, 1 month ago (2014-11-10 15:13:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684683003/1
6 years, 1 month ago (2014-11-10 16:16:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35624)
6 years, 1 month ago (2014-11-10 18:04:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684683003/1
6 years, 1 month ago (2014-11-10 18:41:14 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 19:38:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185057

Powered by Google App Engine
This is Rietveld 408576698