Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 711033002: Referrer Policy: Add a flag to reduce `referer` granularity by default [2/2] (Closed)

Created:
6 years, 1 month ago by Mike West
Modified:
6 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@default
Project:
chromium
Visibility:
Public.

Description

Referrer Policy: Add a flag to reduce `referer` granularity by default [2/2] [1/2] Blink: https://codereview.chromium.org/684683003/ [2/2] Chromium: This patch. BUG=431711 TBR=isherman@chromium.org Committed: https://crrev.com/ae2d6039687df226bbe1c91f0ef36d4ff658d435 Cr-Commit-Position: refs/heads/master@{#303599}

Patch Set 1 #

Total comments: 1

Patch Set 2 : histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Mike West
This too.
6 years, 1 month ago (2014-11-10 14:27:34 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/711033002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/711033002/diff/1/chrome/app/generated_resources.grd#newcode6217 chrome/app/generated_resources.grd:6217: + Reduce default `referer` header granularity. no backticks ...
6 years, 1 month ago (2014-11-10 14:54:21 UTC) #3
jochen (gone - plz use gerrit)
btw, won't work without a patch to histograms.xml
6 years, 1 month ago (2014-11-10 14:54:33 UTC) #4
Mike West
On 2014/11/10 14:54:33, jochen (OOO) wrote: > btw, won't work without a patch to histograms.xml ...
6 years, 1 month ago (2014-11-10 15:19:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711033002/20001
6 years, 1 month ago (2014-11-11 05:48:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/23386)
6 years, 1 month ago (2014-11-11 05:51:44 UTC) #9
Mike West
Ilya: TBRing you for the histograms change. Since I just copy/pasted what the test told ...
6 years, 1 month ago (2014-11-11 07:14:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711033002/20001
6 years, 1 month ago (2014-11-11 07:15:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-11 07:42:00 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ae2d6039687df226bbe1c91f0ef36d4ff658d435 Cr-Commit-Position: refs/heads/master@{#303599}
6 years, 1 month ago (2014-11-11 07:43:26 UTC) #15
Ilya Sherman
6 years, 1 month ago (2014-11-11 20:54:32 UTC) #16
Message was sent while issue was closed.
histograms.xml lgtm.  I've been thinking it would be nice to split off a
"autogenerated_histograms.xml" file that doesn't need OWNERS approval to be
updated, but I haven't gotten around to doing so yet...

Powered by Google App Engine
This is Rietveld 408576698