Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 684383002: Delete a ton more dead vertical writing mode code. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@writingmode1
Project:
mojo
Visibility:
Public.

Description

Delete a ton more dead vertical writing mode code. No change in behavior. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ead6c7a61cfce5bfd93e6f72367dc31c06594eb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -597 lines) Patch
M sky/engine/core/rendering/EllipsisBox.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/InlineBox.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 7 chunks +11 lines, -25 lines 0 comments Download
M sky/engine/core/rendering/InlineTextBox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 6 chunks +5 lines, -30 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +6 lines, -24 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 9 chunks +13 lines, -47 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 4 chunks +6 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/RenderCombineText.cpp View 2 chunks +1 line, -48 lines 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.cpp View 5 chunks +6 lines, -15 lines 0 comments Download
M sky/engine/core/rendering/RenderGeometryMap.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderGrid.cpp View 6 chunks +0 lines, -36 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 10 chunks +14 lines, -41 lines 0 comments Download
M sky/engine/core/rendering/RenderLineBoxList.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderReplaced.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderText.cpp View 5 chunks +7 lines, -15 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 2 chunks +1 line, -10 lines 0 comments Download
M sky/engine/core/rendering/RootInlineBox.cpp View 4 chunks +15 lines, -45 lines 0 comments Download
M sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp View 3 chunks +11 lines, -47 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 3 chunks +5 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 5 chunks +19 lines, -47 lines 0 comments Download
M sky/engine/platform/geometry/RoundedRect.h View 2 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/platform/geometry/RoundedRect.cpp View 2 chunks +5 lines, -35 lines 0 comments Download
D sky/engine/platform/text/WritingMode.h View 1 chunk +0 lines, -59 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
This depends on https://codereview.chromium.org/688213002
6 years, 1 month ago (2014-10-30 01:53:04 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-10-30 02:02:23 UTC) #3
ojan
6 years, 1 month ago (2014-10-30 02:08:17 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ead6c7a61cfce5bfd93e6f72367dc31c06594eb6.

Powered by Google App Engine
This is Rietveld 408576698