Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: sky/engine/core/rendering/RenderView.cpp

Issue 684383002: Delete a ton more dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode1
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderText.cpp ('k') | sky/engine/core/rendering/RootInlineBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderView.cpp
diff --git a/sky/engine/core/rendering/RenderView.cpp b/sky/engine/core/rendering/RenderView.cpp
index f2d136e3d9b739ff198c924a7d8175fe85f890c8..9996347da340e7815f7245b4382105a0bd4d5439 100644
--- a/sky/engine/core/rendering/RenderView.cpp
+++ b/sky/engine/core/rendering/RenderView.cpp
@@ -139,7 +139,7 @@ bool RenderView::shouldDoFullPaintInvalidationForNextLayout() const
// and discrete paint invalidation rects, so marking full paint invalidation here is more likely to cost less.
// Otherwise, per-descendant paint invalidation is more likely to avoid unnecessary full paint invalidation.
- if (!style()->isHorizontalWritingMode() || width() != viewWidth())
+ if (width() != viewWidth())
return true;
if (height() != viewHeight()) {
@@ -346,15 +346,6 @@ void RenderView::invalidatePaintForViewAndCompositedLayers()
void RenderView::mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect& rect, const PaintInvalidationState* state) const
{
- if (style()->isFlippedBlocksWritingMode()) {
- // We have to flip by hand since the view's logical height has not been determined. We
- // can use the viewport width and height.
- if (style()->isHorizontalWritingMode())
- rect.setY(viewHeight() - rect.maxY());
- else
- rect.setX(viewWidth() - rect.maxX());
- }
-
// Apply our transform if we have one (because of full page zooming).
if (!paintInvalidationContainer && layer() && layer()->transform())
rect = layer()->transform()->mapRect(rect);
« no previous file with comments | « sky/engine/core/rendering/RenderText.cpp ('k') | sky/engine/core/rendering/RootInlineBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698