Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 683483004: aa rect renderer takes a gpu on construction (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

aa rect renderer takes a gpu on construction BUG=skia: Committed: https://skia.googlesource.com/skia/+/b44293e712ca22815fcab3fdec8ec21c661781cf

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -62 lines) Patch
M src/gpu/GrAARectRenderer.h View 1 3 chunks +17 lines, -23 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 10 chunks +28 lines, -34 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
6 years, 1 month ago (2014-10-28 01:51:12 UTC) #2
bsalomon
https://codereview.chromium.org/683483004/diff/1/src/gpu/GrAARectRenderer.h File src/gpu/GrAARectRenderer.h (right): https://codereview.chromium.org/683483004/diff/1/src/gpu/GrAARectRenderer.h#newcode72 src/gpu/GrAARectRenderer.h:72: static int aaStrokeRectIndexCount(bool miterStroke); static funcs begin with a ...
6 years, 1 month ago (2014-10-28 13:33:57 UTC) #3
joshualitt
feedback incorporated
6 years, 1 month ago (2014-10-28 14:28:15 UTC) #4
bsalomon
lgtm
6 years, 1 month ago (2014-10-28 15:02:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683483004/20001
6 years, 1 month ago (2014-10-28 15:04:25 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 15:12:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as b44293e712ca22815fcab3fdec8ec21c661781cf

Powered by Google App Engine
This is Rietveld 408576698