Issue 68343016: [Object.observe] Don't force normalization of elements for observed objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68343016: [Object.observe] Don't force normalization of elements for observed objects (Closed)

Created:
7 years, 1 month ago by rafaelw

Modified:
7 years, 1 month ago

Reviewers:
danno

CC:
v8-dev, rossberg, Jakob Kummerow, adamk

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland [Object.observe] Don't force normalization of elements for observed objects Original Issue: https://codereview.chromium.org/29353003/ Note that this version of the patch includes logic for bailing out of compiled ArrayPush/ArrayPop calls if the array is observed (see stub-cache-*) R=danno@chromium.org BUG=v8:2946 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=17769

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -65 lines)			Patch
M	src/arm/ic-arm.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	src/builtins.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/mips/ic-mips.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	src/objects.h	View	5 chunks	+8 lines, -12 lines	0 comments	Download
M	src/objects.cc	View	8 chunks	+4 lines, -15 lines	0 comments	Download
M	src/objects-debug.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	test/mjsunit/harmony/object-observe.js	View	1 chunk	+63 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

rafaelw

7 years, 1 month ago (2013-11-14 21:47:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r17769 (presubmit successful).