Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 68343016: [Object.observe] Don't force normalization of elements for observed objects (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/ic-mips.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1687 matching lines...) Expand 10 before | Expand all | Expand 10 after
1698 Handle<String> name, 1698 Handle<String> name,
1699 Code::StubType type) { 1699 Code::StubType type) {
1700 // ----------- S t a t e ------------- 1700 // ----------- S t a t e -------------
1701 // -- a2 : name 1701 // -- a2 : name
1702 // -- ra : return address 1702 // -- ra : return address
1703 // -- sp[(argc - n - 1) * 4] : arg[n] (zero-based) 1703 // -- sp[(argc - n - 1) * 4] : arg[n] (zero-based)
1704 // -- ... 1704 // -- ...
1705 // -- sp[argc * 4] : receiver 1705 // -- sp[argc * 4] : receiver
1706 // ----------------------------------- 1706 // -----------------------------------
1707 1707
1708 // If object is not an array, bail out to regular call. 1708 // If object is not an array or is observed, bail out to regular call.
1709 if (!object->IsJSArray() || !cell.is_null()) return Handle<Code>::null(); 1709 if (!object->IsJSArray() ||
1710 !cell.is_null() ||
1711 Handle<JSArray>::cast(object)->map()->is_observed()) {
1712 return Handle<Code>::null();
1713 }
1710 1714
1711 Label miss; 1715 Label miss;
1712 1716
1713 GenerateNameCheck(name, &miss); 1717 GenerateNameCheck(name, &miss);
1714 1718
1715 Register receiver = a1; 1719 Register receiver = a1;
1716 1720
1717 // Get the receiver from the stack. 1721 // Get the receiver from the stack.
1718 const int argc = arguments().immediate(); 1722 const int argc = arguments().immediate();
1719 __ lw(receiver, MemOperand(sp, argc * kPointerSize)); 1723 __ lw(receiver, MemOperand(sp, argc * kPointerSize));
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
1953 Handle<String> name, 1957 Handle<String> name,
1954 Code::StubType type) { 1958 Code::StubType type) {
1955 // ----------- S t a t e ------------- 1959 // ----------- S t a t e -------------
1956 // -- a2 : name 1960 // -- a2 : name
1957 // -- ra : return address 1961 // -- ra : return address
1958 // -- sp[(argc - n - 1) * 4] : arg[n] (zero-based) 1962 // -- sp[(argc - n - 1) * 4] : arg[n] (zero-based)
1959 // -- ... 1963 // -- ...
1960 // -- sp[argc * 4] : receiver 1964 // -- sp[argc * 4] : receiver
1961 // ----------------------------------- 1965 // -----------------------------------
1962 1966
1963 // If object is not an array, bail out to regular call. 1967 // If object is not an array or is observed, bail out to regular call.
1964 if (!object->IsJSArray() || !cell.is_null()) return Handle<Code>::null(); 1968 if (!object->IsJSArray() ||
1969 !cell.is_null() ||
1970 Handle<JSArray>::cast(object)->map()->is_observed()) {
1971 return Handle<Code>::null();
1972 }
1965 1973
1966 Label miss, return_undefined, call_builtin; 1974 Label miss, return_undefined, call_builtin;
1967 Register receiver = a1; 1975 Register receiver = a1;
1968 Register elements = a3; 1976 Register elements = a3;
1969 GenerateNameCheck(name, &miss); 1977 GenerateNameCheck(name, &miss);
1970 1978
1971 // Get the receiver from the stack. 1979 // Get the receiver from the stack.
1972 const int argc = arguments().immediate(); 1980 const int argc = arguments().immediate();
1973 __ lw(receiver, MemOperand(sp, argc * kPointerSize)); 1981 __ lw(receiver, MemOperand(sp, argc * kPointerSize));
1974 // Check that the receiver isn't a smi. 1982 // Check that the receiver isn't a smi.
(...skipping 1196 matching lines...) Expand 10 before | Expand all | Expand 10 after
3171 // ----------------------------------- 3179 // -----------------------------------
3172 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_MissForceGeneric); 3180 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_MissForceGeneric);
3173 } 3181 }
3174 3182
3175 3183
3176 #undef __ 3184 #undef __
3177 3185
3178 } } // namespace v8::internal 3186 } } // namespace v8::internal
3179 3187
3180 #endif // V8_TARGET_ARCH_MIPS 3188 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/ic-mips.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698