src/builtins.cc - Issue 68343016: [Object.observe] Don't force normalization of elements for observed objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 68343016: [Object.observe] Don't force normalization of elements for observed objects (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index 758967ec08d875ce5ccab732d4d120366e6a5079..40772724266dc0277a59da827c77d2dbaa76aefa 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -311,6 +311,7 @@ static inline MaybeObject* EnsureJSArrayWithWritableFastElements(

Heap* heap, Object* receiver, Arguments* args, int first_added_arg) {

if (!receiver->IsJSArray()) return NULL;

JSArray* array = JSArray::cast(receiver);

+ if (array->map()->is_observed()) return NULL;

HeapObject* elms = array->elements();

Map* map = elms->map();

if (map == heap->fixed_array_map()) {

« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »